Bug 6487 - libdbus_convenience should be linked -static
Summary: libdbus_convenience should be linked -static
Status: RESOLVED FIXED
Alias: None
Product: dbus
Classification: Unclassified
Component: core (show other bugs)
Version: unspecified
Hardware: x86 (IA32) other
: high normal
Assignee: Havoc Pennington
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-04-04 01:39 UTC by Julio Merino
Modified: 2010-12-18 01:36 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
Proposed patch. (1.10 KB, patch)
2006-04-04 01:39 UTC, Julio Merino
Details | Splinter Review
Proposed patch (ChangeLog entry corrected). (1.12 KB, patch)
2006-04-04 01:41 UTC, Julio Merino
Details | Splinter Review

Description Julio Merino 2006-04-04 01:39:37 UTC
The libdbus_convenience library is incorrectly built under DragonFly BSD.  As
Joerg Sonnenberger explains (the author of the patch), the convenience library
needs to be built -static, as otherwise binutils generates incorrect relocation
entries for errno on DragonFly.

If -static is not given to that library, final binaries such as dbus-daemon are
linked with the convenience library using the PIC objects, which is incorrect.

As the name implies, this is a convenience library so it has to be linked
statically.
Comment 1 Julio Merino 2006-04-04 01:39:52 UTC
Created attachment 5180 [details] [review]
Proposed patch.
Comment 2 Julio Merino 2006-04-04 01:41:05 UTC
Created attachment 5181 [details] [review]
Proposed patch (ChangeLog entry corrected).

The previous attachment missed to refer to the appropriate bug report in the
proposed ChangeLog entry.  This one is correct.
Comment 3 Ralf Habacker 2010-12-18 01:36:50 UTC
recent dbus code has renamed the convencience library to libdbus_internal. The internal library is build static 

## this library is the same as libdbus, but exports all the symbols
## and is only used for static linking within the dbus package.
noinst_LTLIBRARIES=libdbus-internal.la

so it looks to me that this bug is already implemented and could be closed.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.