Bug 65271 - xf86-video-openchrome-0.3.3: add prototypes
Summary: xf86-video-openchrome-0.3.3: add prototypes
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Driver/openchrome (show other bugs)
Version: unspecified
Hardware: Other NetBSD
: medium normal
Assignee: Openchrome development list
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-02 20:58 UTC by Thomas Klausner
Modified: 2013-06-19 15:13 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments
Patch fixing the issue. (1011 bytes, text/plain)
2013-06-02 20:58 UTC, Thomas Klausner 		no flags Details
fixup patch (619 bytes, patch)
2013-06-04 12:30 UTC, Xavier Bachelot 		no flags Details | Splinter Review
Cleanup patch (964 bytes, patch)
2013-06-04 16:57 UTC, Thomas Klausner 		no flags Details | Splinter Review
View All

Description Thomas Klausner 2013-06-02 20:58:10 UTC 
Created attachment 80165 [details]
Patch fixing the issue.

From NetBSD's xsrc:
add some prototypes to via_driver.h
Originally from Christos Zoulas <christos@NetBSD.org>
Comment 1 Xavier Bachelot 2013-06-03 18:55:24 UTC 
Committed, thanks for the patch.
Comment 2 Daniel Drake 2013-06-03 20:54:55 UTC 
What was the issue here?

This patch breaks compile for me. Some of the added prototypes are for static functions, such as ViaDisplayEnableDVO. gcc doesn't accept non-static prototypes for static functions.
Comment 3 Xavier Bachelot 2013-06-04 12:30:28 UTC 
Created attachment 80289 [details] [review]
fixup patch

oops, I should have paid more attention. Here's a fixup patch, I'll push it later.
Comment 4 Thomas Klausner 2013-06-04 16:57:05 UTC 
Created attachment 80298 [details] [review]
Cleanup patch

I'm sorry for the incorrect patch. I should have checked it more closely.

It seems it was mostly needed for an older version of the driver, and has survived the merging process when the latest version was imported.

I think the cleanup patch can remove even more lines; suggestion attached.
Comment 5 Xavier Bachelot 2013-06-19 15:13:42 UTC 
fixed by 200cdb68353e638c78582c0ae571e59c96cfea64

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.