Bug 65362 - Can't connect to account when avatar is too big
Summary: Can't connect to account when avatar is too big
Status: NEW
Alias: None
Product: Telepathy
Classification: Unclassified
Component: gabble (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-04 16:35 UTC by Dan Vrátil
Modified: 2013-06-05 08:05 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dan Vrátil 2013-06-04 16:35:33 UTC
I've accidentally uploaded a big image as my account avatar, now when I try to connect to that account, I get

mcd_connection_invalidated_cb: Proxy destroyed (WOCKY_XMPP_STREAM_ERROR_POLICY_VIOLATION (#13): XML stanza is too big)

and connection is terminated.

Either it should not be possible to upload an avatar that does not fit into a stanza, or the stanza should be just ignored. Simply put, it should still be possible to connect :-)

This happens with a slightly outdated git build of telepathy-mission-control and telepathy-gabble.
Comment 1 Simon McVittie 2013-06-04 17:42:40 UTC
Unfortunately, we can't know how much your XMPP server will allow in a stanza.

If your UI allowed changing your account's avatar (as stored in Mission Control) while offline, you could do that, and we'd upload the the new (presumably smaller) avatar instead. I don't think Empathy allows that (feature request?), but it's meant to work.

A forget-avatar subcommand in mc-tool would also make sense.
Comment 2 Simon McVittie 2013-06-04 17:48:04 UTC
XMPP Core says:

> A deployed server's
> maximum stanza size MUST NOT be smaller than 10000 bytes, which
> reflects a reasonable compromise between the benefits of
> expressiveness for originating entities and the costs of stanza
> processing for servers.

but Gabble shouldn't impose that limit, because perfectly ordinary Base64'd avatars are already likely to exceed it.
Comment 3 Xavier Claessens 2013-06-05 08:05:21 UTC
Gabble could catch that error and retry to connect without the avatar. Or at least we need to display an explicit messages to user with a "change avatar and reconnect" button.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.