Bug 65490 - [HSW 9.1 Bisected]Piglit spec/NV_primitive_restart/primitive-restart-draw-mode-quads fail
Summary: [HSW 9.1 Bisected]Piglit spec/NV_primitive_restart/primitive-restart-draw-mod...
Status: VERIFIED FIXED
Alias: None
Product: Mesa
Classification: Unclassified
Component: Drivers/DRI/i965 (show other bugs)
Version: 9.1
Hardware: All Linux (All)
: high major
Assignee: Carl Worth
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-07 03:21 UTC by lu hua
Modified: 2013-08-21 08:18 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:


Attachments

Description lu hua 2013-06-07 03:21:31 UTC
System Environment:
--------------------------
Arch:           x86_64
Platform:       Haswell
Libdrm:		(master)libdrm-2.4.45-6-g1669a67d063e82a58dae4d906015172d471e9a2a
Mesa:		(9.1)4ed7e384347268ef2a578dd33326c6940e091dab
Xserver:	(server-1.13-branch)xorg-server-1.13.4
Xf86_video_intel:(master)2.21.8-23-g70fa080d02bff9742523cea52c875d9447a78bfd
Cairo:		(master)17dc312221c294b120bd159e01f5f566c6ec4a2d
Libva:		(master)32e44bcf45ee0f4a345ccaedda1d45079e8186ed
Libva_intel_driver:(master)31caada2967b94705d78ab7f6d07965ad7f13d42
Kernel:	(drm-intel-fixes) 53d3b4d7778daf15900867336c85d3f8dd70600c

Bug detailed description:
-------------------------
It fails on haswell with mesa 9.1 branch. It works well on master branch.
spec/NV_primitive/restart_primitive-restart-draw-mode-quad_strip also fails and has same bisect commit.

Bisect shows:f1c0c7b3b341abe4ad3f31ef3066ef6bb428b692 is the first bad commit
commit f1c0c7b3b341abe4ad3f31ef3066ef6bb428b692
Author:     Paul Berry <stereotype441@gmail.com>
AuthorDate: Fri Apr 5 20:15:39 2013 -0700
Commit:     Kenneth Graunke <kenneth@whitecape.org>
CommitDate: Wed Jun 5 11:10:22 2013 -0700

    i965/gen7.5: Allow HW primitive restart for all primitive types.

    Gen7.5 (Haswell) hardware supports primitive restart for all primitive
    types.  It also handles all possible primitive restart indices.
    Rather than specialize both can_cut_index_handle_restart_index() and
    the switch statement in can_cut_index_handle_prims() for Haswell, just
    return early if the hardware is Haswell because we know it can handle
    everything.

    Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
    Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
    Reviewed-by: Eric Anholt <eric@anholt.net>
    (cherry picked from commit 34efd9214d4daabb56f7f39bdbd6836472979b76)

output:
Probe at (27,231)
  Left: 0.000000 0.000000 0.000000 0.000000
  Right: 0.250980 0.250980 1.000000 1.000000
PIGLIT: {'result': 'fail' }


Reproduce steps:
----------------
1. xinit
2. ./bin/primitive-restart-draw-mode quads -auto
Comment 1 lu hua 2013-07-25 08:27:34 UTC
It fixed on mesa 9.2 branch.
Comment 2 Paul Berry 2013-07-25 22:14:07 UTC
This is failing because commit a7388f8e6f72b31fa05c824ae1c42bf86794f878 wasn't cherry-picked to 9.1.  I've sent a cherry-pick of a7388f8e6f72b31fa05c824ae1c42bf86794f878 to mesa-stable.
Comment 3 lu hua 2013-08-21 08:18:06 UTC
Fixed.
Comment 4 lu hua 2013-08-21 08:18:26 UTC
Verified.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.