Bug 656 - Typo in CVS commit to composite
Summary: Typo in CVS commit to composite
Status: CLOSED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Server/General (show other bugs)
Version: unspecified
Hardware: x86 (IA32) Linux (All)
: high normal
Assignee: Keith Packard
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-05-22 01:02 UTC by Tim Vismor
Modified: 2011-10-15 17:21 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Description Tim Vismor 2004-05-22 01:02:09 UTC
While looking over a commit to compinit.c I think I spotted a minor typo. I
don't currently have the source on disk so I'll submit a description of the
problem rather than an actual patch.

Identification of CVS commit:
-----------------------------

Index: compinit.c
===================================================================
RCS file: /cvs/xserver/xserver/composite/compinit.c,v
retrieving revision 1.12
retrieving revision 1.13
diff -u -d -r1.12 -r1.13
--- a/compinit.c        13 May 2004 21:25:51 -0000      1.12
+++ b/compinit.c        21 May 2004 03:32:27 -0000      1.13
@@ -89,63 +89,99 @@
 
Section of the commit with a typo:
----------------------------------

+       /*
+        * Allocate vid list for this depth
+        */
+       vids[numAlternate] = xalloc (sizeof (VisualID));
+       if (!vids)
+           continue;
+       depths[numAlternate] = depth;

Correction of typo:
-------------------

+       /*
+        * Allocate vid list for this depth
+        */
+       vids[numAlternate] = xalloc (sizeof (VisualID));
-       if (!vids)
+       if (!vids[numAlternate])
+           continue;
+       depths[numAlternate] = depth;
Comment 1 Eric Anholt 2004-08-12 17:10:11 UTC
Appears to be fixed in CVS (X.Org and xserver).


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.