Bug 65752 - userdel "-f" is used inconsistently
Summary: userdel "-f" is used inconsistently
Status: RESOLVED FIXED
Alias: None
Product: accountsservice
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Matthias Clasen
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-14 11:47 UTC by Marius Vollmer
Modified: 2014-01-10 17:46 UTC (History)
3 users (show)

See Also:
i915 platform:
i915 features:


Attachments
fix (949 bytes, patch)
2014-01-10 17:41 UTC, Matthias Clasen
Details | Splinter Review

Description Marius Vollmer 2013-06-14 11:47:08 UTC
The daemon passed "-f" to userdel together with "-r", when the user's files should be removed as well.

However, -f also overrides the check whether the user has any current processes.

If "-f" is wanted for its effects on file removal, it should be used always to get consistent behavior with regard to the other things that "-f" does.  If the other things are not wanted, it shouldn't be used with "-r" either.

I can't really say whether "-f" should always be used or never, though.

(Maybe userdel needs fixing so that it doesn't overload -f with so many things.)
Comment 1 Matthias Clasen 2014-01-10 17:41:57 UTC
Created attachment 91829 [details] [review]
fix
Comment 2 Ray Strode [halfline] 2014-01-10 17:46:21 UTC
pushed


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.