Bug 65753 - user->login_history is never unreffed
Summary: user->login_history is never unreffed
Status: RESOLVED FIXED
Alias: None
Product: accountsservice
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Matthias Clasen
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-14 13:10 UTC by Marius Vollmer
Modified: 2013-06-18 13:40 UTC (History)
3 users (show)

See Also:
i915 platform:
i915 features:

Attachments
user: Don't leak login_history (753 bytes, patch)
2013-06-18 12:35 UTC, Stef Walter 		Details | Splinter Review
View All

Description Marius Vollmer 2013-06-14 13:10:28 UTC 
I don't think it matters much, but login_history doesn't seem to be cleaned nup properly in user_finalize.

        g_variant_unref (user->login_history);

should be all that is needed, no?

(I noticed this just from reading the code, so I might well be misunderstanding things.)
Comment 1 Matthias Clasen 2013-06-14 14:18:53 UTC 
Looks like it, indeed
Comment 2 Stef Walter 2013-06-18 12:35:17 UTC 
Created attachment 81000 [details] [review]
user: Don't leak login_history

Marius, can you take a quick look?
Comment 3 Marius Vollmer 2013-06-18 13:36:36 UTC 
Comment on attachment 81000 [details] [review]
user: Don't leak login_history

Review of attachment 81000 [details] [review]:
-----------------------------------------------------------------

Looks good.
Comment 4 Stef Walter 2013-06-18 13:40:45 UTC 
Attachment 81000 [details] pushed as ae9a4fc - user: Don't leak login_history

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.