Bug 6592 - SaveSet windows with SaveSetUnmap are still visibly reparented
Summary: SaveSet windows with SaveSetUnmap are still visibly reparented
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Server/General (show other bugs)
Version: 6.9.0
Hardware: x86 (IA32) Linux (All)
: high normal
Assignee: Xorg Project Team
QA Contact: Xorg Project Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-04-14 01:37 UTC by Dan Winship
Modified: 2009-06-09 09:02 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments

Description Dan Winship 2006-04-14 01:37:41 UTC 
The XFixes spec at http://webcvs.freedesktop.org/xlibs/FixesExt/protocol?view=markup
says:

    Having embedded windows suddenly appear at the top level can confuse users,
    so XFIXES also permits these windows to remain unmapped instead of being
    remapped.

The wording here and the implementation in HandleSaveSet (in
xserver/xorg/dix/window.c) both seem to assume that something causes SaveSet
windows to be unmapped by default when their parent is destroyed, and so
SaveSetUnmap can be implemented by just *not* calling MapWindow() on the
window. But it doesn't seem to actually work like that. HandleSaveSet needs
to actually call UnmapWindow (or whatever) when saving a window with the
SaveSetUnmap flag, or the window will get visibly reparented, resulting in
the user confusion that the extension was supposed to be fixing.

qv: http://bugzilla.gnome.org/show_bug.cgi?id=160132#c15
Comment 1 Daniel Stone 2007-02-27 01:31:30 UTC 
Sorry about the phenomenal bug spam, guys.  Adding xorg-team@ to the QA contact so bugs don't get lost in future.
Comment 2 Dan Winship 2009-06-09 09:02:03 UTC 
this was fixed in 722c51960dd4948b8a64f8eff115fa69da597ef9. (Hi Owen.)

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.