Bug 65989 - Text selections are drawn over each other
Summary: Text selections are drawn over each other
Status: RESOLVED FIXED
Alias: None
Product: poppler
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: poppler-bugs
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-21 03:01 UTC by Jason Crain
Modified: 2013-06-21 16:36 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
PDF with closely spaced lines of text (888 bytes, application/pdf)
2013-06-21 03:01 UTC, Jason Crain 		Details
image of PDF as rendered by poppler-glib-demo (9.81 KB, image/png)
2013-06-21 03:04 UTC, Jason Crain 		Details
Draw glyphs after selection background (6.18 KB, patch)
2013-06-21 03:09 UTC, Jason Crain 		Details | Splinter Review
View All

Description Jason Crain 2013-06-21 03:01:36 UTC 
Created attachment 81144 [details]
PDF with closely spaced lines of text

When multiple lines of text are selected, TextSelectionPainter will draw selections over each other, hiding the previous line with the selection background of the current line.  Attached PDF has closely spaced lines of text to show this issue.

This is easiest to see on the selections page of popper-glib-demo.  Evince has its own issue which makes this a bit harder to see.
Comment 1 Jason Crain 2013-06-21 03:04:14 UTC 
Created attachment 81145 [details]
image of PDF as rendered by poppler-glib-demo

Image of this PDF with the selection rendered by poppler-glib-demo.
Comment 2 Jason Crain 2013-06-21 03:09:23 UTC 
Created attachment 81146 [details] [review]
Draw glyphs after selection background

Attached patch changes TextSelectionPainter so that glyphs are drawn only after the entire background is drawn.
Comment 3 Carlos Garcia Campos 2013-06-21 16:36:33 UTC 
Comment on attachment 81146 [details] [review]
Draw glyphs after selection background

Review of attachment 81146 [details] [review]:
-----------------------------------------------------------------

This is a great idea. Pushed to git master, thank you!

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.