Bug 66045 - Fix mouse header include on DragonFly and FreeBSD
Summary: Fix mouse header include on DragonFly and FreeBSD
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Server/General (show other bugs)
Version: git
Hardware: All BSD (Others)
: medium normal
Assignee: Xorg Project Team
QA Contact: Xorg Project Team
URL:
Whiteboard:
Keywords: patch
Depends on:
Blocks: xserver-1.14
  Show dependency treegraph
 
Reported: 2013-06-22 11:48 UTC by Francois Tigeot
Modified: 2013-07-17 04:56 UTC (History)
3 users (show)

See Also:
i915 platform:
i915 features:


Attachments
[PATCH] Fix mouse header include on DragonFly and FreeBSD (1.16 KB, text/plain)
2013-06-22 11:48 UTC, Francois Tigeot
no flags Details

Description Francois Tigeot 2013-06-22 11:48:14 UTC
Created attachment 81210 [details]
[PATCH] Fix mouse header include on DragonFly and FreeBSD

Recent xserver versions fail to compile on DragonFly:

In file included from xf86Config.c:60:0:
../../../hw/xfree86/os-support/xf86_OSlib.h:284:27: fatal error: machine/mouse.h: No such file or directory
compilation terminated.

This is caused by an outdated header location check.

The attached patch greatly simplifies the check, fixing the compilation issue in the process.
Comment 1 Peter Hutterer 2013-06-30 22:04:33 UTC
Please sign off your patch and send it to xorg-devel@lists.x.org. This increases the chance that the BSD guys have a look at it, I'm not familiar enough with BSDs to really pass muster.
Comment 2 Francois Tigeot 2013-07-15 18:57:49 UTC
This patch has been tested on both FreeBSD and DragonFly and has been present in the DragonFly ports tree ever since xorg-server 1.12 started to be used.

What can I do to convince an Xorg developer to push it ?
Comment 3 Alan Coopersmith 2013-07-15 19:36:26 UTC
(In reply to comment #2)
> What can I do to convince an Xorg developer to push it ?

See Peter's reply in comment #1.   The Xorg server development process does
not allow us to push directly to the Xorg master repo - all patches must be
sent to xorg-devel for review to be either applied or git pulled into the
server.

http://www.x.org/wiki/Development/Documentation/SubmittingPatches
Comment 4 Francois Tigeot 2013-07-15 20:12:11 UTC
Thanks for the explanation, it wasn't obvious there was a formal process in place and what the "signed off" expression meant.
Comment 5 Peter Hutterer 2013-07-17 04:56:59 UTC
commit 791121e00692e12cb4c38c8d018bd72eb5081eb7
Author: François Tigeot <ftigeot@wolfpond.org>
Date:   Mon Jul 15 21:54:26 2013 +0200

    Fix mouse header include on DragonFly and FreeBSD


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.