Bug 6620 - Maybe missing "else" keyword
Summary: Maybe missing "else" keyword
Status: CLOSED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Server/General (show other bugs)
Version: unspecified
Hardware: x86 (IA32) Linux (All)
: high enhancement
Assignee: Keith Packard
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-04-16 21:32 UTC by Alberto Mardegan
Modified: 2011-10-15 17:21 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Description Alberto Mardegan 2006-04-16 21:32:22 UTC
In the file hw/kdrive/ati/ati_dma.c, around line 791 there is this piece of code:
=========
    if (atic->is_r200) {
        MMIO_OUT32(mmio, RADEON_REG_CP_CSQ_CNTL,
            RADEON_CSQ_PRIPIO_INDDIS);
        atis->cce_pri_size = MMIO_IN32(mmio, RADEON_REG_CP_CSQ_CNTL) &
            R200_CSQ_CNT_PRIMARY_MASK;
        MMIO_OUT32(mmio, RADEON_REG_ME_CNTL, RADEON_ME_MODE_FREE_RUN);
    } if (atic->is_radeon) {
        MMIO_OUT32(mmio, RADEON_REG_CP_CSQ_CNTL,
            RADEON_CSQ_PRIPIO_INDDIS);
        atis->cce_pri_size = MMIO_IN32(mmio, RADEON_REG_CP_CSQ_CNTL) &
            RADEON_CSQ_CNT_PRIMARY_MASK;
        MMIO_OUT32(mmio, RADEON_REG_ME_CNTL, RADEON_ME_MODE_FREE_RUN);
    } else {
=========
The second "if" starts after a closing brace, so I guess an "else" is missing,
or at least a newline.
Comment 1 Tilman Sauerbeck 2007-03-31 06:54:58 UTC
Thanks, fixed in f2808005f4ee72c5fd7f5f3dcca181306485113e.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.