Created attachment 81549 [details] Sample file Hello, After some research, I can't see any post concerning this bug. When I edited a form so as to modify an interger format, I got a plain window with 3 buttons. I'm using the LibO 4.1.0.1 RC1 version. I tried t do the same thing using LibO 4.0.2.2., I got the expected window. I illustrated the bug in the attached file. I also attached a sample file. Steps to reproduce. 1. Open a nex base file. 2. Creat a table using assistant. 3. Creat a form using the new table, opting to modify when creating. 4. Select an integer unit. 5. Open the properties window. 6. Try to modify format for this zone. Hope that I've been enough clear. Feel free to ask for more details. Sorry if this bug have already been reported. Bunty
Created attachment 81550 [details] Screenshot to illustrate the bug with comparisons
I can confirm this bug. If you want to format a formatting field it doesn't work any more. The dialog is broken.
Caolán, you are the Dialogs expert I know... Can you get me a clue to find why this dialog now has only "OK / Cancel / Help"? I've found out that it is started by pcr::FormComponentPropertyHandler::impl_dialogFormatting_nothrow in file extensions/source/propctrlr/formcomponenthandler.cxx, but beyond that I'm a bit clueless. The only possibly-relevant commit I see is commit bd272cd3daf873fcc69c2cc794ffda821be7fedf Author: Caolán McNamara <caolanm@redhat.com> Date: Thu Jan 24 13:18:00 2013 +0000 rename SfxSingleTabDialog to SfxNoLayoutSingleTabDialog Change-Id: I4922b719bf819879909e9949bf7946f20914d1e5 but a mere rename should not make troubles like that... But maybe something from the close history of this commit that justified the rename? Maybe the behaviour of SfxSingleTabDialog was changed?
These "single" tab dialogs are super pain to handle within the layout stuff. Bottom line is that converted to layout tabpage need a SfxSingleTabDialog parent and create themselves as children of get_content_area of that dialog. While non layout tabpages get SfxNoLayoutSingleTabDialog parents, and make themselves direct children of that dialog.
Caolan McNamara committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=092281f1e7022ee26e3659cc1c54ac0dd73a4382 Resolves: fdo#66252 format->number for controls is busted The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Caolan McNamara committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=eb39f90f071c03f8f9e61a0f129a060ffcfb96eb Related: fdo#66252 RID_SVXPAGE_NUMBERFORMAT needs a layout parent The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Caolan McNamara committed a patch related to this issue. It has been pushed to "libreoffice-4-1": http://cgit.freedesktop.org/libreoffice/core/commit/?id=b38a0aacb035ed924084473e57901b09df1c74c9&h=libreoffice-4-1 Related: fdo#66252 RID_SVXPAGE_NUMBERFORMAT needs a layout parent It will be available in LibreOffice 4.1. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Caolan McNamara committed a patch related to this issue. It has been pushed to "libreoffice-4-1": http://cgit.freedesktop.org/libreoffice/core/commit/?id=a28ffcc7b6ea979a3c730ab76a97ecab01f6efb6&h=libreoffice-4-1 Resolves: fdo#66252 format->number for controls is busted It will be available in LibreOffice 4.1. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
that should do it
These two patches fix the issue for me.