Bug 66334 - Patches for git master
Summary: Patches for git master
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Driver/openchrome (show other bugs)
Version: git
Hardware: All NetBSD
: medium normal
Assignee: Openchrome development list
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-28 17:04 UTC by Thomas Klausner
Modified: 2013-09-06 14:54 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
Patch for the first issue. (845 bytes, text/plain)
2013-06-28 17:04 UTC, Thomas Klausner 		no flags Details
Patch for the second issue. (835 bytes, patch)
2013-06-28 17:04 UTC, Thomas Klausner 		no flags Details | Splinter Review
Patch for the third issue. (1.10 KB, patch)
2013-06-28 17:05 UTC, Thomas Klausner 		no flags Details | Splinter Review
New via_drm.h header (9.82 KB, text/plain)
2013-07-05 22:26 UTC, James Simmons 		no flags Details
View All

Description Thomas Klausner 2013-06-28 17:04:30 UTC 
Created attachment 81649 [details]
Patch for the first issue.

I tried compiling latest git master with clang and had to fix some issues.

1. Some DRM_FORMAT_* symbols are used without including the appropriate header.
2. The wrong format string is used for an unsigned long.
3. Unsigned values are tested for being less than zero.

The attached patches fix these problems.

Let me know if you prefer separate bug reports for the separate patches.
Comment 1 Thomas Klausner 2013-06-28 17:04:53 UTC 
Created attachment 81650 [details] [review]
Patch for the second issue.
Comment 2 Thomas Klausner 2013-06-28 17:05:10 UTC 
Created attachment 81651 [details] [review]
Patch for the third issue.
Comment 3 James Simmons 2013-07-05 22:26:54 UTC 
Created attachment 82097 [details]
New via_drm.h header
Comment 4 James Simmons 2013-07-05 22:29:27 UTC 
Applied your patches. Could you try the new via_drm.h header. I want to make sure I don't break the BSD support.
Comment 5 Thomas Klausner 2013-07-06 07:21:57 UTC 
I've tried compiling git head with the via_drm.h from attachment 4 [details] [review], and it still compiled fine both with gcc and clang.

I don't have the hardware, so I can't test functionality.

Thanks for applying the patches!
Comment 6 James Simmons 2013-09-06 14:54:17 UTC 
All patches applied. We can close this ticket.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.