mesa: 27f2df2507a591eaf8ff6c2953fd39e60ad85482 (master) $ scons [...] Compiling src/gallium/tests/unit/translate_test.c ... src/gallium/tests/unit/translate_test.c: In function ‘main’: src/gallium/tests/unit/translate_test.c:263:10: warning: passing argument 5 of ‘translate[0]->run_elts’ makes integer from pointer without a cast [enabled by default] src/gallium/tests/unit/translate_test.c:263:10: note: expected ‘unsigned int’ but argument is of type ‘unsigned char *’ src/gallium/tests/unit/translate_test.c:263:10: error: too few arguments to function ‘translate[0]->run_elts’ src/gallium/tests/unit/translate_test.c:265:10: warning: passing argument 5 of ‘translate[1]->run_elts’ makes integer from pointer without a cast [enabled by default] src/gallium/tests/unit/translate_test.c:265:10: note: expected ‘unsigned int’ but argument is of type ‘unsigned char *’ src/gallium/tests/unit/translate_test.c:265:10: error: too few arguments to function ‘translate[1]->run_elts’ src/gallium/tests/unit/translate_test.c:267:10: warning: passing argument 5 of ‘translate[0]->run_elts’ makes integer from pointer without a cast [enabled by default] src/gallium/tests/unit/translate_test.c:267:10: note: expected ‘unsigned int’ but argument is of type ‘unsigned char *’ src/gallium/tests/unit/translate_test.c:267:10: error: too few arguments to function ‘translate[0]->run_elts’ src/gallium/tests/unit/translate_test.c:269:10: warning: passing argument 5 of ‘translate[1]->run_elts’ makes integer from pointer without a cast [enabled by default] src/gallium/tests/unit/translate_test.c:269:10: note: expected ‘unsigned int’ but argument is of type ‘unsigned char *’ src/gallium/tests/unit/translate_test.c:269:10: error: too few arguments to function ‘translate[1]->run_elts’ 1c2e5c223da28cdffe156b6b430fcdf638909021 is the first bad commit commit 1c2e5c223da28cdffe156b6b430fcdf638909021 Author: Zack Rusin <zackr@vmware.com> Date: Thu Jun 27 20:40:10 2013 -0400 draw/translate: fix instancing We were incorrectly computing the buffer offset when using the instances. The buffer offset is always equal to: start_instance * stride + (instance_num / instance_divisor) * stride We were completely ignoring the start instance quite often producing instances that completely wrong, e.g. if start instance = 5, instance divisor = 2, then on the first iteration it should be: 5 * stride, not (5/2) * stride as we'd have currently, and if start instance = 1, instance divisor = 3, then on the first iteration it should be: 1 * stride, not 0 as we'd have. This fixes it and adjusts all the code to the changes. Signed-off-by: Zack Rusin <zackr@vmware.com> :040000 040000 cbd8d10d710bd44b366c7341c77d8a18dcd40bda 76b1ca3ea48bdb3cd7320e5a674979d77d28ab2d M src bisect run success
Vinson, I'm not seeing that error here with current git (559adef2). Retest?
Zack fixed soon after.
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.