Created attachment 82414 [details] [review]
Add DBusActivatable

Created attachment 82415 [details] [review]
Warn about OnlyShowIn in Action groups

Created attachment 82416 [details] [review]
Admit that we validate more than 1.0

It seems that we should probably do a proper desktop file spec 1.1 now.

Changes vs. 1.0 based on a diff since when the version was bumped to 1.0:

 - encoding specified as utf-8

 - strengthen wording about having proper extension, removing "magic detection"
   suggestion

 - added recommendation for reverse DNS naming of desktop files

 - clarify that numbers in the file are to be interpreted as per C locale

 - add semicolon as a trailing character on multiple value keys, even if
   only one value is given

 - version field changed to string (from numeric)

 - add D-Bus activation

 - add desktop actions

 - add Keywords


There is also a change in one of the examples removing .png from an icon name.  I don't understand that change, but I assume it has something to do with icon theme?

Thanks Matthias, I've committed all patches.

One thing that we should likely do, though, is add a check for DBusActivatable to make sure that the .desktop file has a name that at least looks like a reverse DNS name. One easy way is to make sure there's at least a "." in there. Leaving the bug opened for this.

(In reply to comment #4)
> There is also a change in one of the examples removing .png from an icon
> name.  I don't understand that change, but I assume it has something to do
> with icon theme?

Yes. Values for the Icon shouldn't have an extension, unless it's a path (and not an icon name).

Sorry for the noise, reassigning to new maintainer.

Commit 5e8047d0d7a622dfd19dba0310ad58d8b4e2f16b implements what Vincent describes in comment 5. Hopefully that concludes this bug -- closing as fixed.