Bug 66947 - Make userdb cache as a built-in feature, non-optional
Summary: Make userdb cache as a built-in feature, non-optional
Status: RESOLVED FIXED
Alias: None
Product: dbus
Classification: Unclassified
Component: core (show other bugs)
Version: 1.5
Hardware: Other All
: low trivial
Assignee: Havoc Pennington
QA Contact:
URL:
Whiteboard: review?
Keywords: patch
Depends on:
Blocks:
 
Reported: 2013-07-16 05:10 UTC by Chengwei Yang
Modified: 2013-09-13 14:01 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments
[PATCH] Make userdb cache as a built-in feature (3.89 KB, patch)
2013-09-04 07:18 UTC, Chengwei Yang 		Details | Splinter Review
View All

Description Chengwei Yang 2013-07-16 05:10:48 UTC 

    


    


      



        
          Comment 1
        

        
          Simon McVittie

        

        
        

        
          2013-07-16 12:19:00 UTC
        

      






I think there's a wider question here. Why would you disable the userdb cache? What do you gain by doing so? Why is it even an option?

The no-userdb-cache code path is clearly not well-tested (Bug #15589, Bug #17133) so I'm very tempted to say "it is not optional".

On Bug #15589, Havoc wrote:
> I'm pretty sure the bus is outrageously slow with this disabled,
> too (at least if you have any policy rules based on group membership)

    


    


      



        
          Comment 2
        

        
          Chengwei Yang

        

        
        

        
          2013-07-16 13:13:43 UTC
        

      






(In reply to comment #1)
> I think there's a wider question here. Why would you disable the userdb
> cache? What do you gain by doing so? Why is it even an option?

I have no special use case for disable userdb case, just because it's a configurable option from user point of view.

It's also fine to me just make it as a mandatory feature. Is that acceptable?

> 
> The no-userdb-cache code path is clearly not well-tested (Bug #15589, Bug
> #17133) so I'm very tempted to say "it is not optional".
> 
> On Bug #15589, Havoc wrote:
> > I'm pretty sure the bus is outrageously slow with this disabled,
> > too (at least if you have any policy rules based on group membership)

    


    


      



        
          Comment 3
        

        
          Chengwei Yang

        

        
        

        
          2013-09-04 07:18:39 UTC
        

      






Created attachment 85174 [details] [review]
[PATCH] Make userdb cache as a built-in feature

    


    


      



        
          Comment 4
        

        
          Simon McVittie

        

        
        

        
          2013-09-13 14:01:05 UTC
        

      






Merged, thanks! 1.7.6

    



  






  














    


  Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.