Bug 67651 - Add mute key of Gigabyte U2442 to the force release list
Summary: Add mute key of Gigabyte U2442 to the force release list
Status: RESOLVED FIXED
Alias: None
Product: systemd
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Zbigniew Jedrzejewski-Szmek
QA Contact: systemd-bugs
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-02 07:28 UTC by phw
Modified: 2013-08-07 12:55 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
treat GIGABYTE U2442 like i1520M (998 bytes, patch)
2013-08-05 02:51 UTC, Zbigniew Jedrzejewski-Szmek
Details | Splinter Review

Description phw 2013-08-02 07:28:07 UTC
I have a GIGABYTE U2442 laptop. It's mute key (0xa0) should be added to the force-release list. Other media keys seem to work fine. The laptop can be identified via

ATTR{[dmi/id]sys_vendor}=="GIGABYTE", ATTR{[dmi/id]product_name}=="U2442"

I don't know how general this issue is and if this could be extended to other models of the same vendor.
Comment 1 Zbigniew Jedrzejewski-Szmek 2013-08-05 02:51:52 UTC
Created attachment 83637 [details] [review]
treat GIGABYTE U2442 like i1520M

Does the keyboard work properly with the following patch? 
(Note that systemd-206 or later is required, since there have been significant changes in the area of keyboard mappings lately.)

To test, you can apply the patch to 60-keyboard.hwdb as installed in the filesystem, and do 'udevadm --debug hwdb --update', and reboot.
Comment 2 phw 2013-08-07 07:34:41 UTC
Thanks for the quick response and the patch. I have updated to systemd 206, removed the custom udev rule I had used and followed your instructions. Works as expected.

The only thing I noticed that the patch would apply the force release to all the keys mute (0xa0), volume up (0xb0), and volume down (0xae). For my keyboard only the mute key is affected, though, and I had applied the force-release only to that key. Don't know how harmful it is to apply the force-release also to the other two buttons.
Comment 3 Zbigniew Jedrzejewski-Szmek 2013-08-07 12:55:35 UTC
(In reply to comment #2)
> The only thing I noticed that the patch would apply the force release to all
> the keys mute (0xa0), volume up (0xb0), and volume down (0xae). For my
> keyboard only the mute key is affected, though.
I modified the patch to only modify mute.

Applied in http://cgit.freedesktop.org/systemd/systemd/commit/?id=0787758.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.