Bug 67674 - check-doc-syntax.sh test fails
Summary: check-doc-syntax.sh test fails
Status: RESOLVED FIXED
Alias: None
Product: cairo
Classification: Unclassified
Component: general (show other bugs)
Version: 1.12.12
Hardware: x86-64 (AMD64) Linux (All)
: medium normal
Assignee: Chris Wilson
QA Contact: cairo-bugs mailing list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: cairo-1.14
  Show dependency treegraph
 
Reported: 2013-08-02 15:05 UTC by Ivailo Monev
Modified: 2013-09-16 15:18 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
log files (20.07 KB, text/plain)
2013-08-02 15:05 UTC, Ivailo Monev
Details

Description Ivailo Monev 2013-08-02 15:05:08 UTC
Created attachment 83545 [details]
log files
Comment 1 Uli Schlachter 2013-09-15 12:58:11 UTC
Uhm. What exactly are you doing to get this result? The error message is "check-doc-syntax.awk", but that file is in git, is in Makefile.am's EXTRA_DIST and also is in the 1.12.12 release .tar.xz. In other words, I cannot reproduce this problem at all.
Comment 2 Ivailo Monev 2013-09-15 14:27:33 UTC
The file is indeed present in the tarball, I looked for it. I tried different things and the problem turned out to be bad interpreter, instead of /usr/bin/awk I have /bin/awk so src/check-doc-syntax.awk fails.

Can you do something about that, detect the path to awk and adjust it in src/check-doc-syntax.awk or you consider this a distribution specific bug?
Comment 3 Uli Schlachter 2013-09-16 11:01:13 UTC
commit 966bf2fe6a8c29f4d10b20f982a4ab198a441c78
Author: Uli Schlachter <psychon@znc.in>
Date:   Sun Sep 15 16:58:05 2013 +0200

    check-doc-syntax: Don't hardcode path to awk
    
    Instead of expecting awk in /usr/bin, this commit changes the code to call awk
    through a shell so that $PATH is searched.
    
    Since this awk script shouldn't really be called manually, this is done by
    removing the shebang from the awk script, marking it non-executable and fixing
    up the caller.
    
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=67674
    Reviewed-by: Bryce Harrington <b.harrington@samsung.com>
    Signed-off-by: Uli Schlachter <psychon@znc.in>
Comment 4 Ivailo Monev 2013-09-16 15:18:33 UTC
Many thanks!


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.