Bug 67953 - FTBFS as part of Gabble: incomplete dependencies
Summary: FTBFS as part of Gabble: incomplete dependencies
Status: RESOLVED FIXED
Alias: None
Product: Wocky
Classification: Unclassified
Component: General (show other bugs)
Version: git master
Hardware: Other All
: medium normal
Assignee: Simon McVittie
QA Contact: Telepathy bugs list
URL:
Whiteboard:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2013-08-09 15:36 UTC by Simon McVittie
Modified: 2013-08-09 15:57 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:

Attachments
Fix examples' and tests' dependencies (8.43 KB, patch)
2013-08-09 15:36 UTC, Simon McVittie 		Details | Splinter Review
View All

Description Simon McVittie 2013-08-09 15:36:06 UTC 
Created attachment 83895 [details] [review]
Fix examples' and tests' dependencies

All Automake products automatically depend on their SOURCES and
everything identifiable as a file in their LDADD, unless you set their
DEPENDENCIES, which take precedence (and have "replace", not "add",
semantics). As a result, setting DEPENDENCIES is actually harmful here:
it makes the tests and examples not depend on their own source code!

For the one test that has non-trivial extra dependencies,
use EXTRA_x_DEPENDENCIES, which has the desired semantics.
Comment 1 Vivek Dasmohapatra 2013-08-09 15:38:35 UTC 
Comment on attachment 83895 [details] [review]
Fix examples' and tests' dependencies

Review of attachment 83895 [details] [review]:
-----------------------------------------------------------------

Seems legit, +1
Comment 2 Simon McVittie 2013-08-09 15:57:17 UTC 
fixed in gabble-0.18, thanks

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.