Bug 68191 - Overhaul autotools with regard to introspection and API version
Summary: Overhaul autotools with regard to introspection and API version
Status: RESOLVED FIXED
Alias: None
Product: GeoClue
Classification: Unclassified
Component: General (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Geoclue Bugs
QA Contact: Geoclue Bugs
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-16 15:25 UTC by Marvin Schmidt
Modified: 2014-02-05 22:15 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
modernize introspection generation, consolidate API version into a single place, update .gitignore (8.01 KB, text/plain)
2013-08-16 15:25 UTC, Marvin Schmidt
Details
consolidate api version string in one place (1.73 KB, patch)
2013-09-15 07:49 UTC, Marvin Schmidt
Details | Splinter Review
make bumping api version a one-stop-change (1.76 KB, patch)
2014-02-05 20:07 UTC, Marvin Schmidt
Details | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marvin Schmidt 2013-08-16 15:25:54 UTC
Created attachment 84147 [details]
modernize introspection generation, consolidate API version into a single place, update .gitignore

With the commit d2f4e97eed04955742adc7b6107456a645ad3685 (configure: Update for geoclue-2.0.pc rename) changed the API version of the installed pkgconfig file to 2.0, but all the other API version references where left untouched. This motivated me to consolidate the API version into a single place, so it's easier to read and just a one-stop-change for future API changes

While at it, I also updated the introspection generation autotools to the 'modern way of doing it' (as far as I can tell)
Comment 1 Marvin Schmidt 2013-09-15 07:49:07 UTC
Created attachment 85841 [details] [review]
consolidate api version string in one place

Updated the patch after most of it got obsoleted by the removal of the client-side library in http://cgit.freedesktop.org/geoclue/commit/?id=ea67aa34a255b8f368e7a7afd965e584db01ae56
Comment 2 Zeeshan Ali 2014-02-05 14:10:23 UTC
Oops, totally forgot about this one. Could you please rebase it?
Comment 3 Marvin Schmidt 2014-02-05 20:07:56 UTC
Created attachment 93488 [details] [review]
make bumping api version a one-stop-change

No problem - done! ;-)
Comment 4 Zeeshan Ali 2014-02-05 22:15:43 UTC
Thanks so much!


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.