Bug 6840 - Buttons not working on Stylistic 2300
Summary: Buttons not working on Stylistic 2300
Status: RESOLVED INVALID
Alias: None
Product: xorg
Classification: Unclassified
Component: Input/fpit (show other bugs)
Version: unspecified
Hardware: x86 (IA32) Linux (All)
: high major
Assignee: Xorg Project Team
QA Contact: Xorg Project Team
URL:
Whiteboard: 2011BRB_Reviewed
Keywords:
Depends on:
Blocks:
 
Reported: 2006-05-05 00:21 UTC by Marcos
Modified: 2018-06-12 19:10 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments

Description Marcos 2006-05-05 00:21:38 UTC
I have installed xorg from Debian unstable on a Stylistic 2300 (active pen).

Without the "Passive" option in xorg.conf, the cursor moves fine, but sends no
button events. 

However, the buttons do work in the bios configuration menus, and running the
simplepen test program in a text console
(http://nocat.net/download/contrib/simplepen.c) also reports both buttons as
working. It is also very useful for pen calibration!

I believe the problem lies somewhere in the following bits of code from the
xf86Fpit.c:

    #define PROXIMITY_BIT	0x20 /* DMC: This was 0x40 but the chart says its bit
5 which is 0x20 */

Maybe it should be 0x40 after all, at least for some models of Stylistic (or
maybe not - see below).

So we would be using the wrong bit to set the variable prox (or setting it
backwards?):

  prox = (priv->fpitData[loop] & PROXIMITY_BIT) ? 0 : 1;

And when we test proximity for non-passive pens, since prox might be set
incorrectly, we assume we are in hover mode when we are not, and the buttons are
always reset to 0 and never get processed:

    if (priv->fpitPassive) {
	.......
    else { /* the active pen's buttons map directly to the mouse buttons */
			if (!prox) buttons=0; /* We are in hover mode, so no buttons */

I have also tried setting the "Passive" option in xorg.conf, with very strange
results.

I do get click events, but not when I bring the pen towards the screen, as one
might expect, but when I pull it away, as if the proximity bit were inverted.
The side button on the stylus also works - but again only if I keep the pen at
certain distance from the screen.

So the bug definitely has to do with mis-reading or mis-interpreting the
proximity bit.

Many thanks,
Marcos
Comment 1 Daniel Stone 2007-02-27 01:31:58 UTC
Sorry about the phenomenal bug spam, guys.  Adding xorg-team@ to the QA contact so bugs don't get lost in future.
Comment 2 Jeremy Huddleston Sequoia 2011-10-17 00:59:00 UTC
This is likely not going to be fixed without a patch from you ;)  ... I don't 
know if anyone here has hardware to test this, and you seem to have done quite 
a bit of diagnosis already.  Have you investigated further or found a fix?
Comment 3 Jeremy Huddleston Sequoia 2011-10-17 01:01:40 UTC
Also, if you can test the patch from #16470, that would be appreciated.
Comment 4 Adam Jackson 2018-06-12 19:10:08 UTC
Mass closure: This bug has been untouched for more than six years, and is not
obviously still valid. Please reopen this bug or file a new report if you continue to experience issues with current releases.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.