Bug 68609 - LVM2 support
Summary: LVM2 support
Status: VERIFIED WONTFIX
Alias: None
Product: udisks
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
Hardware: Other All
: medium enhancement
Assignee: David Zeuthen (not reading bugmail)
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-27 13:32 UTC by Marius Vollmer
Modified: 2013-09-09 15:08 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:


Attachments
LVM2 support (203.75 KB, patch)
2013-08-27 13:32 UTC, Marius Vollmer
Details | Splinter Review

Description Marius Vollmer 2013-08-27 13:32:15 UTC
Created attachment 84713 [details] [review]
LVM2 support

Here is a patch to add LVM2 support to UDisks2.
Comment 1 Marius Vollmer 2013-08-27 13:33:21 UTC
Known shortcomings are:

 - RAID, mirrors and striped volumes are not supported yet.

 - "pvmove" jobs can not be cancelled, interrupted pvmoves can not
   be resumed, and externally started pvmoves do not show up as jobs.

 - Clients must explicitly poll to keep certain properties up-to-date.

 - No automated tests.

 - Not really checked/reviewed yet for memory leaks and race conditions...

I'll continue to work on this and will update this bug.
Comment 2 David Zeuthen (not reading bugmail) 2013-08-27 17:08:15 UTC
As I said a couple of months ago when we discussed this via email, I think this is a bad idea. Please move this to its own daemon/project or something; I don't want it in udisks.

Also - preemptively - I would advise you to not just stash the patch in the Fedora/RHEL udisks RPM; doing so is tantamount to a fork and if you do this (and I can understand that you have a need), you should do it properly which includes renaming the project so there is no confusion that this is your code/ideas and not mine.

Thanks for your consideration.
Comment 3 Stef Walter 2013-09-09 15:08:27 UTC
(In reply to comment #2)
> As I said a couple of months ago when we discussed this via email, I think
> this is a bad idea. Please move this to its own daemon/project or something;
> I don't want it in udisks.

Any chance you could document your reasoning/opinion/details in a public place so the questions don't keep coming up? Please forgive me if I've missed it ... I did search around for more details on mailing list, git logs and such.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.