Bug 68843 - "sna: Expand the array of fake outputs if the last is used" causes startup crash
Summary: "sna: Expand the array of fake outputs if the last is used" causes startup crash
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Driver/intel (show other bugs)
Version: git
Hardware: x86-64 (AMD64) Linux (All)
: medium normal
Assignee: Chris Wilson
QA Contact: Intel GFX Bugs mailing list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-02 11:47 UTC by Andreas Reis
Modified: 2013-09-02 12:07 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
Xorg crash log (25.44 KB, text/plain)
2013-09-02 11:47 UTC, Andreas Reis
no flags Details

Description Andreas Reis 2013-09-02 11:47:54 UTC
Created attachment 85055 [details]
Xorg crash log

Can't start the X-Server with that commit applied, instant crash.

The 3.11 i915 DRM driver changed the handling of available outputs, on 3.10 I'd get something (harmless) like "more than 8 outputs detected", which on 3.11 is gone. Maybe that has something to do with it?

xorg-git
Haswell 4770 (only iGPU)
Linux 3.11-rc7
Comment 1 Chris Wilson 2013-09-02 12:07:57 UTC
commit 529db4d5edf396757f4f10a2b3aac55ad7e0bbc1
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date:   Mon Sep 2 13:04:49 2013 +0100

    sna: Check for output->randr_output before dereferencing
    
    As we may call the ->detect() routines during the fallback initial
    probing, we need to handle the case where the output callbacks are
    called before RandR is setup.
    
    Regresion from
    commit 8ecb758697af42e8e68edee0d1945986470a9c04
    Author: Chris Wilson <chris@chris-wilson.co.uk>
    Date:   Sat Aug 31 19:44:50 2013 +0100
    
        sna: Expand the array of fake outputs if the last is used
    
    Reported-by: Andreas Reis <andreas.reis@gmail.com>
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=68843
    Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.