The GNOME OSTree images don't have any connection managers in them. They only have telepathy-glib and telepathy-mission-control. On such a setup tp_list_connection_managers_async does not invoke its callback. One visible consequence of this is that the "Add Account" button in the Online Accounts panel does not present the corresponding dialog, if you are using the OSTree images.
This is problematic also on distributions which might not want to install any telepathy CM by default but still rely on gnome-online-accounts "add accounts" to work properly to setup Email accounts..
Created attachment 95948 [details] [review] connection-manager: factor out all_cms_prepared()
Created attachment 95949 [details] [review] tp_list_connection_managers_async: terminate properly if there is no CM
Comment on attachment 95949 [details] [review] tp_list_connection_managers_async: terminate properly if there is no CM Review of attachment 95949 [details] [review]: ----------------------------------------------------------------- Both patches look fine, apart from a minor bug in the regression test. ::: tests/dbus/list-cm-no-cm.c @@ +66,5 @@ > + GError *error = NULL; > + > + /* This test relies on D-Bus not finding any service file so tweak > + * TP_TESTS_SERVICES_DIR to point to an empty directory. */ > + dir = g_dir_make_tmp ("tp-glib-tests.XXXXXX", &error); At the end, please save the result of tp_tests_run_with_bus(), g_rmdir() this directory, *then* exit with the saved result.
(In reply to comment #4) > Comment on attachment 95949 [details] [review] [review] > tp_list_connection_managers_async: terminate properly if there is no CM > > Review of attachment 95949 [details] [review] [review]: > ----------------------------------------------------------------- > > Both patches look fine, apart from a minor bug in the regression test. > > ::: tests/dbus/list-cm-no-cm.c > @@ +66,5 @@ > > + GError *error = NULL; > > + > > + /* This test relies on D-Bus not finding any service file so tweak > > + * TP_TESTS_SERVICES_DIR to point to an empty directory. */ > > + dir = g_dir_make_tmp ("tp-glib-tests.XXXXXX", &error); > > At the end, please save the result of tp_tests_run_with_bus(), g_rmdir() > this directory, *then* exit with the saved result. I've done that and merged the branch. Fixed for 0.23.3.
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.