Bug 69182 - File descriptor leak in _dbus_command_for_pid()
Summary: File descriptor leak in _dbus_command_for_pid()
Status: RESOLVED FIXED
Alias: None
Product: dbus
Classification: Unclassified
Component: core (show other bugs)
Version: unspecified
Hardware: All All
: low minor
Assignee: Havoc Pennington
QA Contact:
URL:
Whiteboard: review+
Keywords: patch
Depends on:
Blocks:
 
Reported: 2013-09-10 15:39 UTC by Sviatoslav Chagaev
Modified: 2013-09-13 18:47 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
Patch for 1.6 (843 bytes, patch)
2013-09-10 15:40 UTC, Sviatoslav Chagaev 		Details | Splinter Review
Patch for 1.7 (843 bytes, patch)
2013-09-10 15:40 UTC, Sviatoslav Chagaev 		Details | Splinter Review
View All

Description Sviatoslav Chagaev 2013-09-10 15:39:50 UTC 
A file descriptor is leaked in _dbus_command_for_pid() function if it fails to read.
Comment 1 Sviatoslav Chagaev 2013-09-10 15:40:20 UTC 
Created attachment 85572 [details] [review]
Patch for 1.6
Comment 2 Sviatoslav Chagaev 2013-09-10 15:40:39 UTC 
Created attachment 85573 [details] [review]
Patch for 1.7
Comment 3 Chengwei Yang 2013-09-11 05:16:59 UTC 
Comment on attachment 85573 [details] [review]
Patch for 1.7

Review of attachment 85573 [details] [review]:
-----------------------------------------------------------------

Looks good.
Comment 4 Simon McVittie 2013-09-13 11:27:57 UTC 
r+ from me too, applying.
Comment 5 Simon McVittie 2013-09-13 13:51:41 UTC 
Fixed in git for 1.6.16, 1.7.6
Comment 6 Sviatoslav Chagaev 2013-09-13 18:47:48 UTC 
(In reply to comment #5)
> Fixed in git for 1.6.16, 1.7.6

Thanks!

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.