Build fails on current git master (v4.0-173-g81ac0db) with the following error: CCLD module-tunnel-sink.la CCLD module-tunnel-source.la .libs/module_tunnel_sink_la-module-tunnel.o: In function `module_tunnel_sink_LTX_pa__init': /build/pulseaudio/src/modules/module-tunnel.c:1987: undefined reference to `xcb_connect' /build/pulseaudio/src/modules/module-tunnel.c:1990: undefined reference to `xcb_connection_has_error' /build/pulseaudio/src/modules/module-tunnel.c:1992: undefined reference to `xcb_disconnect' /build/pulseaudio/src/modules/module-tunnel.c:2235: undefined reference to `xcb_disconnect' /build/pulseaudio/src/modules/module-tunnel.c:2253: undefined reference to `xcb_disconnect' collect2: error: ld returned 1 exit status make[3]: *** [module-tunnel-sink.la] Error 1 make[3]: *** Waiting for unfinished jobs.... .libs/module-tunnel.o: In function `module_tunnel_source_LTX_pa__init': /build/pulseaudio/src/modules/module-tunnel.c:1987: undefined reference to `xcb_connect' /build/pulseaudio/src/modules/module-tunnel.c:1990: undefined reference to `xcb_connection_has_error' /build/pulseaudio/src/modules/module-tunnel.c:1992: undefined reference to `xcb_disconnect' /build/pulseaudio/src/modules/module-tunnel.c:2235: undefined reference to `xcb_disconnect' /build/pulseaudio/src/modules/module-tunnel.c:2253: undefined reference to `xcb_disconnect' collect2: error: ld returned 1 exit status make[3]: *** [module-tunnel-source.la] Error It seems that if HAVE_X11 is defined, module-tunnel.c should link to XCB. Patch attached.
Created attachment 85944 [details] [review] module-tunnel: Fix building with HAVE_X11 Link to the X11 libs (XCB) from the tunnel source and sink modules to fix the following build error: CCLD module-tunnel-source.la .libs/module_tunnel_sink_la-module-tunnel.o: In function `module_tunnel_sink_LTX_pa__init': /build/pulseaudio/src/modules/module-tunnel.c:1987: undefined reference to `xcb_connect'
Thanks! David fixed this today without being aware of your patch: http://cgit.freedesktop.org/pulseaudio/pulseaudio/commit/?id=d909860d8d5f47cb0982797daba7762cd7db3a72 Your patch would have been nicer, because it has the HAVE_X11 check, but David's version works too, because if X11 is not enabled, X11_CFLAGS and X11_LIBS will evaluate to an empty string.
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.