Bug 69507 - Gabble: implement Proto.I.Avatars
Summary: Gabble: implement Proto.I.Avatars
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: gabble (show other bugs)
Version: unspecified
Hardware: Other All
: medium enhancement
Assignee: Guillaume Desmottes
QA Contact: Telepathy bugs list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-18 07:34 UTC by Guillaume Desmottes
Modified: 2013-09-18 10:22 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
protocol: claim to implement Interface.Avatars (2.16 KB, patch)
2013-09-18 09:16 UTC, Guillaume Desmottes
Details | Splinter Review
protocol: implement get_avatar_details() (4.42 KB, patch)
2013-09-18 09:17 UTC, Guillaume Desmottes
Details | Splinter Review
write-mgr-file: write Avatars properties (3.23 KB, patch)
2013-09-18 09:17 UTC, Guillaume Desmottes
Details | Splinter Review

Description Guillaume Desmottes 2013-09-18 07:34:26 UTC
It's basically a matter of
- implement TpBaseProtocolClass->get_avatar_details
- update TpBaseProtocolClass->get_interfaces_array
- update the manager file

See bug #31757 for similar work in Haze.
Comment 1 Guillaume Desmottes 2013-09-18 09:16:50 UTC
Created attachment 86052 [details] [review]
protocol: claim to implement Interface.Avatars
Comment 2 Guillaume Desmottes 2013-09-18 09:17:04 UTC
Created attachment 86053 [details] [review]
protocol: implement get_avatar_details()
Comment 3 Guillaume Desmottes 2013-09-18 09:17:16 UTC
Created attachment 86054 [details] [review]
write-mgr-file: write Avatars properties
Comment 4 Guillaume Desmottes 2013-09-18 09:20:32 UTC
Btw, I noticed that properties from http://telepathy.freedesktop.org/spec/Protocol_Interface_Presence.html aren't exported in the manager file. Is that expected?
Comment 5 Simon McVittie 2013-09-18 09:56:47 UTC
Comment on attachment 86052 [details] [review]
protocol: claim to implement Interface.Avatars

Review of attachment 86052 [details] [review]:
-----------------------------------------------------------------

ideal
Comment 6 Simon McVittie 2013-09-18 09:57:52 UTC
Comment on attachment 86053 [details] [review]
protocol: implement get_avatar_details()

Review of attachment 86053 [details] [review]:
-----------------------------------------------------------------

yes please
Comment 7 Simon McVittie 2013-09-18 09:58:58 UTC
Comment on attachment 86054 [details] [review]
write-mgr-file: write Avatars properties

Review of attachment 86054 [details] [review]:
-----------------------------------------------------------------

ship it
Comment 8 Simon McVittie 2013-09-18 10:06:47 UTC
(In reply to comment #4)
> Btw, I noticed that properties from
> http://telepathy.freedesktop.org/spec/Protocol_Interface_Presence.html
> aren't exported in the manager file. Is that expected?

No, that's a bug.
Comment 9 Guillaume Desmottes 2013-09-18 10:22:52 UTC
Merged to master.

I opened bug #69519 about the presence issue.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.