Bug 69508 - Salut: implement Proto.I.Avatars
Summary: Salut: implement Proto.I.Avatars
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: salut (show other bugs)
Version: unspecified
Hardware: Other All
: medium enhancement
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-18 07:34 UTC by Guillaume Desmottes
Modified: 2013-09-19 11:01 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
constants.py: sync with Gabble (9.11 KB, patch)
2013-09-19 10:11 UTC, Guillaume Desmottes
Details | Splinter Review
protocol: claim that we implement Avatars (1.88 KB, patch)
2013-09-19 10:11 UTC, Guillaume Desmottes
Details | Splinter Review
protocol: implement get_avatar_details() (4.24 KB, patch)
2013-09-19 10:11 UTC, Guillaume Desmottes
Details | Splinter Review
write-mgr-file: write Avatars properties (2.86 KB, patch)
2013-09-19 10:12 UTC, Guillaume Desmottes
Details | Splinter Review

Description Guillaume Desmottes 2013-09-18 07:34:57 UTC
It's basically a matter of
- implement TpBaseProtocolClass->get_avatar_details
- update TpBaseProtocolClass->get_interfaces_array
- update the manager file

See bug #31757 for similar work in Haze.
Comment 1 Guillaume Desmottes 2013-09-19 10:11:23 UTC
Created attachment 86128 [details] [review]
constants.py: sync with Gabble
Comment 2 Guillaume Desmottes 2013-09-19 10:11:38 UTC
Created attachment 86129 [details] [review]
protocol: claim that we implement Avatars
Comment 3 Guillaume Desmottes 2013-09-19 10:11:50 UTC
Created attachment 86130 [details] [review]
protocol: implement get_avatar_details()
Comment 4 Guillaume Desmottes 2013-09-19 10:12:09 UTC
Created attachment 86131 [details] [review]
write-mgr-file: write Avatars properties
Comment 5 Simon McVittie 2013-09-19 10:32:47 UTC
Comment on attachment 86128 [details] [review]
constants.py: sync with Gabble

Review of attachment 86128 [details] [review]:
-----------------------------------------------------------------

::: tests/twisted/constants.py
@@ +97,2 @@
>  
> +CALL_STATE_UNKNOWN = 0,

This is a tuple, unless you delete the comma.
Comment 6 Simon McVittie 2013-09-19 10:33:10 UTC
Comment on attachment 86129 [details] [review]
protocol: claim that we implement Avatars

Review of attachment 86129 [details] [review]:
-----------------------------------------------------------------

OK
Comment 7 Simon McVittie 2013-09-19 10:33:47 UTC
Comment on attachment 86130 [details] [review]
protocol: implement get_avatar_details()

Review of attachment 86130 [details] [review]:
-----------------------------------------------------------------

OK
Comment 8 Simon McVittie 2013-09-19 10:34:03 UTC
Comment on attachment 86131 [details] [review]
write-mgr-file: write Avatars properties

Review of attachment 86131 [details] [review]:
-----------------------------------------------------------------

Looks good, thanks
Comment 9 Simon McVittie 2013-09-19 10:34:51 UTC
Insta-r+ with that comma deleted (and also for deleting it in Gabble).
Comment 10 Guillaume Desmottes 2013-09-19 11:01:52 UTC
fixed and merged to master.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.