Bug 69540 - Some misc 'next' tweaks
Summary: Some misc 'next' tweaks
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: tp-glib (show other bugs)
Version: git master
Hardware: Other All
: medium normal
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL: http://cgit.collabora.com/git/user/xc...
Whiteboard:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2013-09-18 18:24 UTC by Xavier Claessens
Modified: 2013-09-19 15:13 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments

Description Xavier Claessens 2013-09-18 18:24:44 UTC 
Opening a bug to get review comments...
Comment 1 Simon McVittie 2013-09-18 18:29:01 UTC 
19:20 < smcv> 10:18 < smcv> + libtelepathy-glib-1-core.la \
19:20 < smcv> 10:18 < smcv> xclaesse: ^ does that result in the "core" symbols 
              being  duplicated in TelepathyGLibDBus-1.gir?
19:20 < smcv> 10:18 < smcv> xclaesse: (look at the .gir)
Comment 2 Simon McVittie 2013-09-18 18:30:32 UTC 
> No need to pretend we are in telepathy-glib.h when we are in telepathy-glib-d...

OK

> Update UPGRADING file

OK

> protocol name can contain '_' but not '-'

OK when tests pass :-)
Comment 3 Xavier Claessens 2013-09-18 19:05:11 UTC 
(In reply to comment #2)
> > No need to pretend we are in telepathy-glib.h when we are in telepathy-glib-d...
> 
> OK

pushed.

> > Update UPGRADING file
> 
> OK

pushed

> > protocol name can contain '_' but not '-'
> 
> OK when tests pass :-)

Unit tests pass now, branch updated. OK to push ?
Comment 4 Simon McVittie 2013-09-19 15:10:11 UTC 
(In reply to comment #3)
> Unit tests pass now, branch updated. OK to push ?

Yes please!
Comment 5 Xavier Claessens 2013-09-19 15:13:13 UTC 
Thanks.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.