Bug 69619 - Haze: reduce Telepathy 0.x dependence in regression tests
Summary: Haze: reduce Telepathy 0.x dependence in regression tests
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: haze (show other bugs)
Version: git master
Hardware: Other All
: medium normal
Assignee: Simon McVittie
QA Contact: Telepathy bugs list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-20 16:44 UTC by Simon McVittie
Modified: 2013-09-23 15:11 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
1/4] Tests: replace GetSelfHandle calls with property-getting (4.99 KB, patch)
2013-09-20 16:45 UTC, Simon McVittie 		Details | Splinter Review
2/4] haze_im_channel_get_property: fix a TP_SEAL error (878 bytes, patch)
2013-09-20 16:45 UTC, Simon McVittie 		Details | Splinter Review
3/4] simple-caps: stop relying on GetContactCapabilities (1.12 KB, patch)
2013-09-20 16:46 UTC, Simon McVittie 		Details | Splinter Review
4/4] im-channel.c: include config.h first (638 bytes, patch)
2013-09-20 16:46 UTC, Simon McVittie 		Details | Splinter Review
View All

Description Simon McVittie 2013-09-20 16:44:54 UTC 
Like Bug #69618, but for Haze.
Comment 1 Simon McVittie 2013-09-20 16:45:44 UTC 
Created attachment 86211 [details] [review]
1/4] Tests: replace GetSelfHandle calls with property-getting

sed expression:

    s/\.GetSelfHandle()/.Properties.Get(cs.CONN, "SelfHandle")/g

adjusted by hand to add "import constants as cs" where needed.
Comment 2 Simon McVittie 2013-09-20 16:45:56 UTC 
Created attachment 86212 [details] [review]
2/4] haze_im_channel_get_property: fix a TP_SEAL error
Comment 3 Simon McVittie 2013-09-20 16:46:12 UTC 
Created attachment 86213 [details] [review]
3/4] simple-caps: stop relying on GetContactCapabilities

0.99.1 doesn't have it.
Comment 4 Simon McVittie 2013-09-20 16:46:22 UTC 
Created attachment 86214 [details] [review]
4/4] im-channel.c: include config.h first
Comment 5 Guillaume Desmottes 2013-09-23 08:32:49 UTC 
Comment on attachment 86211 [details] [review]
1/4] Tests: replace GetSelfHandle calls with property-getting

Review of attachment 86211 [details] [review]:
-----------------------------------------------------------------

++
Comment 6 Guillaume Desmottes 2013-09-23 08:33:03 UTC 
Comment on attachment 86212 [details] [review]
2/4] haze_im_channel_get_property: fix a TP_SEAL error

Review of attachment 86212 [details] [review]:
-----------------------------------------------------------------

++
Comment 7 Guillaume Desmottes 2013-09-23 08:33:15 UTC 
Comment on attachment 86213 [details] [review]
3/4] simple-caps: stop relying on GetContactCapabilities

Review of attachment 86213 [details] [review]:
-----------------------------------------------------------------

++
Comment 8 Guillaume Desmottes 2013-09-23 08:33:26 UTC 
Comment on attachment 86214 [details] [review]
4/4] im-channel.c: include config.h first

Review of attachment 86214 [details] [review]:
-----------------------------------------------------------------

++

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.