Bug 69671 - rv790 hdmi sound regression since fix audio dto calculation on DCE3+ (v3)
Summary: rv790 hdmi sound regression since fix audio dto calculation on DCE3+ (v3)
Status: RESOLVED FIXED
Alias: None
Product: DRI
Classification: Unclassified
Component: DRM/Radeon (show other bugs)
Version: XOrg git
Hardware: x86-64 (AMD64) Linux (All)
: medium normal
Assignee: Default DRI bug account
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-22 10:38 UTC by Andy Furniss
Modified: 2013-10-01 22:27 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
possible fix (2.36 KB, patch)
2013-09-25 16:09 UTC, Alex Deucher 		no flags Details | Splinter Review
View All

Description Andy Furniss 2013-09-22 10:38:23 UTC 
My rv790 has lost sound over hdmi since -

1518dd8efd47918bb269f1470030592875953f6c is the first bad commit
commit 1518dd8efd47918bb269f1470030592875953f6c
Author: Alex Deucher <alexander.deucher@amd.com>
Date:   Tue Jul 30 17:31:07 2013 -0400

    drm/radeon: fix audio dto calculation on DCE3+ (v3)
    
    Need to set the wallclock ratio and adjust the phase
    and module registers appropriately.  May fix problems
    with audio timing at certain display timings.
    
    v2: properly handle clocks below 24mhz
    v3: rebase r600 changes

Tested with 44,1k and 48k source, screen 50Hz.
Comment 1 Andy Furniss 2013-09-22 11:13:27 UTC 
More testing shows that low Hz modes do still work - in all cases the /1.001 modes behave the same as the exacts.

50p and 60p = fail = no sound and mplayer behaves as is does if the device isn't there = playing too fast.

24p, 25i and 30i are working OK.
Comment 2 Alex Deucher 2013-09-22 14:05:23 UTC 
Possibly related to bug 69675?  Does reverting e6e792092e816bea0797995c886fb057c91d4546 also fix the issue?
Comment 3 Andy Furniss 2013-09-22 14:44:48 UTC 
(In reply to comment #2)
> Possibly related to bug 69675?  Does reverting
> e6e792092e816bea0797995c886fb057c91d4546 also fix the issue?

I may try later but TBH I can't see why it would, the new modes seem to be just extras that don't alter the original modes or even add one in the 50Hz case and they all work for me before 1518dd8efd47918bb269f1470030592875953f6c anyway.
Comment 4 Alex Deucher 2013-09-25 16:09:02 UTC 
Created attachment 86569 [details] [review]
possible fix

Does this patch fix the isssue?
Comment 5 Andy Furniss 2013-09-25 19:21:41 UTC 
(In reply to comment #4)
> Created attachment 86569 [details] [review] [review]
> possible fix
> 
> Does this patch fix the isssue?

Yes, all modes are working with that, thanks.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.