Bug 69773 - Fix some remainging telepathy 1.0 FIXMEs
Summary: Fix some remainging telepathy 1.0 FIXMEs
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: tp-glib (show other bugs)
Version: git master
Hardware: Other All
: medium normal
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL: http://cgit.collabora.com/git/user/ca...
Whiteboard:
Keywords: patch
Depends on: 69431
Blocks: tp-glib-1.0
  Show dependency tree / graph
 
Reported: 2013-09-24 21:12 UTC by Xavier Claessens
Modified: 2014-02-13 16:00 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments

Description Xavier Claessens 2013-09-24 21:12:24 UTC 
account.c and connection-manager.c has a few FIXME about tp 1.0, we should review & fix them.
Comment 1 Simon McVittie 2013-09-25 12:53:47 UTC 
If they're FIXMEs about 1.0, then our past selves obviously thought it would be a compatibility break to fix them. We should get the initial round of 'next' branches working first, so we have a working state for the whole system.
Comment 2 Simon McVittie 2014-02-07 14:49:05 UTC 
The FIXMEs appear to be

* remove tp_account_get_storage_identifier and rename
  tp_account_dup_storage_identifier_variant to
  tp_account_dup_storage_identifier (or maybe make it a const "get")

* remove tp_account_get_storage_specific_information_async and
  rename tp_account_dup_storage_specific_information_vardict_async
  to tp_account_dup_storage_specific_information_async
  (the FIXME comment wanted it to be a const "get" but I don't know why)

* rename tp_connection_manager_dup_protocols to get_protocols
  (but I think that's been superseded by agreeing that our policy is
  "if in doubt, (transfer full) and call it _dup")

Not rocket surgery.
Comment 4 Simon McVittie 2014-02-13 15:56:24 UTC 
(In reply to comment #3)
> http://cgit.collabora.com/git/user/cassidy/telepathy-glib/log/?h=next-misc

Indeed, not rocket surgery. Looks fine.
Comment 5 Guillaume Desmottes 2014-02-13 16:00:49 UTC 
Merged

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.