Bug 69794 - Should not recognize OpenPGP clear text signatures as application/pgp-signature
Summary: Should not recognize OpenPGP clear text signatures as application/pgp-signature
Status: RESOLVED FIXED
Alias: None
Product: shared-mime-info
Classification: Unclassified
Component: freedesktop.org.xml (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Shared Mime Info group
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-25 08:05 UTC by Jérémy Bobbio
Modified: 2013-09-30 09:04 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
patch to stop recognizing OpenPGP clear text signatures as application/pgp-signature (1.63 KB, patch)
2013-09-25 08:05 UTC, Jérémy Bobbio
Details | Splinter Review

Description Jérémy Bobbio 2013-09-25 08:05:19 UTC
Created attachment 86521 [details] [review]
patch to stop recognizing OpenPGP clear text signatures as application/pgp-signature

The mime database currently recognize files beginning with

    -----BEGIN PGP SIGNED MESSAGE-----

as `application/pgp-signature`. Unfortunately, this armor header describes
clear text signatures. They are not covered by this MIME type according
to RFC-3156 and thus should not be recognized as such. This was confirmed by
Werner Koch (main GnuPG developer) on the gnupg-users mailing list:
http://lists.gnupg.org/pipermail/gnupg-users/2013-September/047714.html

The attached patch fixes the issue.
Comment 1 Bastien Nocera 2013-09-30 09:04:59 UTC
commit eb6a25ddfd833070e83c946a636dab8fde80f00d
Author: Jérémy Bobbio <lunar@debian.org>
Date:   Wed Sep 25 09:54:21 2013 +0200

    OpenPGP clear text signatures aren't application/pgp-signature
    
    RFC 3156 do not define the application/pgp-signature MIME type as
    covering clear text signatures. We should not recognize clear text
    signatures armor header as such.
    
    https://bugs.freedesktop.org/show_bug.cgi?id=69794


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.