Bug 69950 - [xkbcomp] the keyword 'default' is ignored
Summary: [xkbcomp] the keyword 'default' is ignored
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: App/xkbcomp (show other bugs)
Version: git
Hardware: Other All
: medium normal
Assignee: Xorg Project Team
QA Contact: Xorg Project Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-30 09:02 UTC by Benno Schulenberg
Modified: 2016-01-08 00:48 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:


Attachments
0001-When-a-file-contains-several-maps-look-for-a-default.patch (3.22 KB, patch)
2013-10-01 09:01 UTC, Ran Benita
no flags Details | Splinter Review
Ran's patch with Tested-by and Acked-by tags added (3.33 KB, patch)
2016-01-06 20:30 UTC, Benno Schulenberg
no flags Details | Splinter Review

Description Benno Schulenberg 2013-09-30 09:02:15 UTC
After adding the keyword 'default' to the "level4" map in symbols/nbsp, and then specifying setxkbmap "us+nbsp", xkbcomp still just takes the first-defined map, the simple-space thing; only when doing setxkbmap "us+nbsp(level4)" do I get the level4 thing.

This is both with a four-year old xkbcomp (from Ubuntu 10.04, that doesn't even know -version yet) and with xkbcomp 1.2.4 from git.
Comment 1 Ran Benita 2013-10-01 09:01:22 UTC
Created attachment 86893 [details] [review]
0001-When-a-file-contains-several-maps-look-for-a-default.patch

Here's a patch to fix this. I'd like to see this in, but since the behavior has always been to just take the first map, this might suddenly change keymaps which inadvertently relied on the broken behavior.

Sergey, as maintainer of xkeyboard-config I think you should decide :)
Comment 2 Benno Schulenberg 2013-10-01 19:47:48 UTC
Confirming that the patch has the intended and desired effect here.

As far as I can tell, applying the patch would only affect the behaviour of specifying a bare "keypad" component -- until now it would select the "overlay" map, after application of the patch it will select the "x11" one.  All other files have the default map as the first one, or do not specify a default at all.

(I've not looked at the files in the *_vndr/ subdirectories, though, but I think they hardly matter.)
Comment 3 Sergey V. Udaltsov 2013-10-01 19:49:43 UTC
> Sergey, as maintainer of xkeyboard-config I think you should decide :)
Please do it. If there are complains - I will deal with it in xk-c. Or people will have to fix their configs. That is really a bug.
Comment 4 Benno Schulenberg 2016-01-06 20:30:21 UTC
Created attachment 120838 [details] [review]
Ran's patch with Tested-by and Acked-by tags added


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.