Bug 70045 - misc Autotools cleanup
Summary: misc Autotools cleanup
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: general (show other bugs)
Version: git master
Hardware: Other All
: medium enhancement
Assignee: Simon McVittie
QA Contact: Telepathy bugs list
URL:
Whiteboard:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2013-10-02 18:00 UTC by Simon McVittie
Modified: 2014-02-14 14:42 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
[haze] Use subdir-objects (compile a/b.c to a/b.lo, not ./b.lo) (839 bytes, patch)
2013-10-02 18:11 UTC, Simon McVittie
Details | Splinter Review
[haze] Use MKDIR_P, not deprecated mkdir_p (1.46 KB, patch)
2013-10-02 18:12 UTC, Simon McVittie
Details | Splinter Review
[haze] .gitignore: ignore everything in build-aux (563 bytes, patch)
2013-10-02 18:12 UTC, Simon McVittie
Details | Splinter Review
[rakia] Use subdir-objects (compile a/b.c to a/b.lo, not ./b.lo) (899 bytes, patch)
2013-10-02 18:13 UTC, Simon McVittie
Details | Splinter Review
[rakia] Use MKDIR_P, not deprecated mkdir_p (978 bytes, patch)
2013-10-02 18:13 UTC, Simon McVittie
Details | Splinter Review
[rakia] Put Autoconf, Automake, Libtool droppings in /build-aux (1.11 KB, patch)
2013-10-02 18:13 UTC, Simon McVittie
Details | Splinter Review
[salut] Use subdir-objects (compile a/b.c to a/b.lo, not ./b.lo) (892 bytes, patch)
2013-10-02 18:14 UTC, Simon McVittie
Details | Splinter Review
[salut] Use AC_PROG_MKDIR_P/MKDIR_P, not deprecated AM_PROG_MKDIR_P/mkdir_p (1.14 KB, patch)
2013-10-02 18:14 UTC, Simon McVittie
Details | Splinter Review
[tpglib] Use MKDIR_P instead of deprecated mkdir_p (1.23 KB, patch)
2013-10-02 18:16 UTC, Simon McVittie
Details | Splinter Review
[tpglib] Use subdir-objects (compile a/b.c to a/b.lo, not ./b.lo) (788 bytes, patch)
2013-10-02 18:16 UTC, Simon McVittie
Details | Splinter Review
[tpglib] Put Autoconf, Automake, Libtool droppings in /build-aux (995 bytes, patch)
2013-10-02 18:16 UTC, Simon McVittie
Details | Splinter Review
[gabble] Use subdir-objects (compile a/b.c to a/b.lo, not ./b.lo) (815 bytes, patch)
2013-10-02 18:18 UTC, Simon McVittie
Details | Splinter Review
[gabble] Put Autoconf, Automake, Libtool droppings in /build-aux (1.12 KB, patch)
2013-10-02 18:19 UTC, Simon McVittie
Details | Splinter Review
[gabble] Use MKDIR_P instead of deprecated mkdir_p (1.54 KB, patch)
2013-10-02 18:19 UTC, Simon McVittie
Details | Splinter Review
[idle] Put Autoconf, Automake, Libtool droppings in /build-aux (1.08 KB, patch)
2013-10-02 18:26 UTC, Simon McVittie
Details | Splinter Review
[idle] Use subdir-objects (compile a/b.c to a/b.lo, not ./b.lo) (833 bytes, patch)
2013-10-02 18:26 UTC, Simon McVittie
Details | Splinter Review
[idle] Use AC_PROG_MKDIR_P/MKDIR_P, not deprecated AM_PROG_MKDIR_P/mkdir_p (1.16 KB, patch)
2013-10-02 18:27 UTC, Simon McVittie
Details | Splinter Review

Description Simon McVittie 2013-10-02 18:00:34 UTC
Various of our projects provoke Autotools warnings.

I'm also quite tempted to bump our minimum Autoconf and Automake version up to something halfway modern, like Automake 1.11 or even 1.13 - it's not as if we test with anything really old anyway. Thoughts?
Comment 1 Simon McVittie 2013-10-02 18:11:49 UTC
Created attachment 86982 [details] [review]
[haze] Use subdir-objects (compile a/b.c to a/b.lo, not ./b.lo)

Automake 2 will make this the default, and 1.14 warns about not
using it. Equivalent to MC commit 1f11065.
Comment 2 Simon McVittie 2013-10-02 18:12:05 UTC
Created attachment 86983 [details] [review]
[haze] Use MKDIR_P, not deprecated mkdir_p

Similar to MC commit 04dd9b4.
Comment 3 Simon McVittie 2013-10-02 18:12:31 UTC
Created attachment 86984 [details] [review]
[haze] .gitignore: ignore everything in build-aux

---

Haze already uses build-aux.
Comment 4 Simon McVittie 2013-10-02 18:13:00 UTC
Created attachment 86985 [details] [review]
[rakia] Use subdir-objects (compile a/b.c to a/b.lo, not ./b.lo)

Automake 2 will make this the default, and 1.14 warns about not
using it. Equivalent to MC commit 1f11065.
Comment 5 Simon McVittie 2013-10-02 18:13:16 UTC
Created attachment 86986 [details] [review]
[rakia] Use MKDIR_P, not deprecated mkdir_p

Similar to MC commit 04dd9b4.
Comment 6 Simon McVittie 2013-10-02 18:13:38 UTC
Created attachment 86987 [details] [review]
[rakia] Put Autoconf, Automake, Libtool droppings in /build-aux

This is basically Mission Control commit c3cba937,
requested in <https://bugs.freedesktop.org/show_bug.cgi?id=69542>.
Comment 7 Simon McVittie 2013-10-02 18:14:24 UTC
Created attachment 86988 [details] [review]
[salut] Use subdir-objects (compile a/b.c to a/b.lo, not ./b.lo)

Automake 2 will make this the default, and 1.14 warns about not
using it. Equivalent to MC commit 1f11065.
Comment 8 Simon McVittie 2013-10-02 18:14:54 UTC
Created attachment 86989 [details] [review]
[salut] Use AC_PROG_MKDIR_P/MKDIR_P, not deprecated  AM_PROG_MKDIR_P/mkdir_p

Similar to MC commit 04dd9b4.

---

Salut already uses build-aux, so no need for that.
Comment 9 Simon McVittie 2013-10-02 18:16:12 UTC
Created attachment 86990 [details] [review]
[tpglib] Use MKDIR_P instead of deprecated mkdir_p

In theory, AC_PROG_MKDIR_P only sets MKDIR_P, although for now it
also sets the deprecated mkdir_p for compatibility with AM_PROG_MKDIR_P.

Similar to MC commit 04dd9b4.
Comment 10 Simon McVittie 2013-10-02 18:16:32 UTC
Created attachment 86991 [details] [review]
[tpglib] Use subdir-objects (compile a/b.c to a/b.lo, not ./b.lo)

Automake 2 will make this the default, and 1.14 warns about not
using it. Equivalent to MC commit 1f11065.
Comment 11 Simon McVittie 2013-10-02 18:16:51 UTC
Created attachment 86992 [details] [review]
[tpglib] Put Autoconf, Automake, Libtool droppings in /build-aux

Equivalent to MC commit c3cba93.
Comment 12 Simon McVittie 2013-10-02 18:18:51 UTC
Created attachment 86993 [details] [review]
[gabble] Use subdir-objects (compile a/b.c to a/b.lo, not ./b.lo)

Automake 2 will make this the default, and 1.14 warns about not
using it. Equivalent to MC commit 1f11065.
Comment 13 Simon McVittie 2013-10-02 18:19:08 UTC
Created attachment 86994 [details] [review]
[gabble] Put Autoconf, Automake, Libtool droppings in /build-aux

This is basically Mission Control commit c3cba937,
requested in <https://bugs.freedesktop.org/show_bug.cgi?id=69542>.
Comment 14 Simon McVittie 2013-10-02 18:19:29 UTC
Created attachment 86995 [details] [review]
[gabble] Use MKDIR_P instead of deprecated mkdir_p

In theory, AC_PROG_MKDIR_P only sets MKDIR_P, although for now it
also sets the deprecated mkdir_p for compatibility with AM_PROG_MKDIR_P.
Comment 15 Simon McVittie 2013-10-02 18:26:23 UTC
Created attachment 86996 [details] [review]
[idle] Put Autoconf, Automake, Libtool droppings in /build-aux

This is basically Mission Control commit c3cba937,
requested in <https://bugs.freedesktop.org/show_bug.cgi?id=69542>.
Comment 16 Simon McVittie 2013-10-02 18:26:40 UTC
Created attachment 86997 [details] [review]
[idle] Use subdir-objects (compile a/b.c to a/b.lo, not ./b.lo)

Automake 2 will make this the default, and 1.14 warns about not
using it. Equivalent to MC commit 1f11065.
Comment 17 Simon McVittie 2013-10-02 18:27:14 UTC
Created attachment 86998 [details] [review]
[idle] Use AC_PROG_MKDIR_P/MKDIR_P, not deprecated  AM_PROG_MKDIR_P/mkdir_p

Similar to MC commit 04dd9b4.
Comment 18 Simon McVittie 2013-10-02 18:27:54 UTC
That's all for now, although we should also do the logger and tp-farstream one day.
Comment 19 Guillaume Desmottes 2013-10-03 08:01:01 UTC
(In reply to comment #0)
> Various of our projects provoke Autotools warnings.
> 
> I'm also quite tempted to bump our minimum Autoconf and Automake version up
> to something halfway modern, like Automake 1.11 or even 1.13 - it's not as
> if we test with anything really old anyway. Thoughts?

I wouldn't mind bumping to 1.13, we depent on recent GLib anyway so people building on old system will have to do some custom build first anyway.
Comment 20 Guillaume Desmottes 2013-10-03 08:01:33 UTC
Comment on attachment 86982 [details] [review]
[haze] Use subdir-objects (compile a/b.c to a/b.lo, not ./b.lo)

Review of attachment 86982 [details] [review]:
-----------------------------------------------------------------

++
Comment 21 Guillaume Desmottes 2013-10-03 08:02:09 UTC
Comment on attachment 86983 [details] [review]
[haze] Use MKDIR_P, not deprecated mkdir_p

Review of attachment 86983 [details] [review]:
-----------------------------------------------------------------

++
Comment 22 Guillaume Desmottes 2013-10-03 08:02:18 UTC
Comment on attachment 86984 [details] [review]
[haze] .gitignore: ignore everything in build-aux

Review of attachment 86984 [details] [review]:
-----------------------------------------------------------------

++
Comment 23 Guillaume Desmottes 2013-10-03 08:03:52 UTC
++ for all the other patches.
Comment 24 Simon McVittie 2014-02-14 12:58:03 UTC
I think I merged all this. It would be great if someone could check!
Comment 25 Guillaume Desmottes 2014-02-14 14:42:24 UTC
(In reply to comment #24)
> I think I merged all this. It would be great if someone could check!

Yep, I just checked. Closing.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.