Unless you disabled deprecated functions in GLib, it should still compile. It's just been deprecated, not removed (eg. it builds fine for me against GLib 2.38).

Created attachment 87297 [details] [review]
ifdef-out g_type_init if Glib version >= 2.36.

(In reply to comment #1)
> Unless you disabled deprecated functions in GLib, it should still compile.
> It's just been deprecated, not removed (eg. it builds fine for me against
> GLib 2.38).

Try with -Werror.

Anyway, it's a tiny change, a couple of lines each in configure.ac and test-tree-magic.c, and it'll have to be fixed sooner or later regardless. Why wait?

As an inducement, patch attached.

Or define GLIB_DISABLE_DEPRECATION_WARNINGS, or using GLIB_VERSION_MIN_REQUIRED. There's no need for configure.ac changes.

(In reply to comment #2)
> Created attachment 87297 [details] [review] [review]
> ifdef-out g_type_init if Glib version >= 2.36.
> 
> (In reply to comment #1)
> > Unless you disabled deprecated functions in GLib, it should still compile.
> > It's just been deprecated, not removed (eg. it builds fine for me against
> > GLib 2.38).
> 
> Try with -Werror.

Why would you compile with deprecated warnings and -Werror?

> Anyway, it's a tiny change, a couple of lines each in configure.ac and
> test-tree-magic.c, and it'll have to be fixed sooner or later regardless.
> Why wait?

Sooner or later? When glib 2.x is obsolete? That'll be a while.

> As an inducement, patch attached.

(In reply to comment #3)
> Or define GLIB_DISABLE_DEPRECATION_WARNINGS, or using
> GLIB_VERSION_MIN_REQUIRED. There's no need for configure.ac changes.

That won't help when the API is removed and it becomes a hard error.

> 
> (In reply to comment #2)
> > Created attachment 87297 [details] [review] [review] [review]
> > ifdef-out g_type_init if Glib version >= 2.36.
> > 
> > (In reply to comment #1)
> > > Unless you disabled deprecated functions in GLib, it should still compile.
> > > It's just been deprecated, not removed (eg. it builds fine for me against
> > > GLib 2.38).
> > 
> > Try with -Werror.
> 
> Why would you compile with deprecated warnings and -Werror?

To catch them and fix them, so that they don't go flying by unnoticed. 

> 
> > Anyway, it's a tiny change, a couple of lines each in configure.ac and
> > test-tree-magic.c, and it'll have to be fixed sooner or later regardless.
> > Why wait?
> 
> Sooner or later? When glib 2.x is obsolete? That'll be a while.

Sounds a bit optimistic. My understanding of the policy is that API can be removed after it has been deprecated for 2 minor revs. Doesn't have to be, but can be.  

Anyway, I have more important stuff to do than to argue about nits.

(In reply to comment #4)
<snip>
> Anyway, I have more important stuff to do than to argue about nits.

So do I.

commit 2397314542265405498ea8c82121c174ed9011a5
Author: Bastien Nocera <hadess@hadess.net>
Date:   Wed Oct 9 22:09:56 2013 +0200

    test: Call g_type_init() with older glib
    
    Only call g_type_init() when compiling against an older glib.
    
    https://bugs.freedesktop.org/show_bug.cgi?id=70255