Bug 70403 - xorg state tracker fails to build due to change in DamageUnregister API
Summary: xorg state tracker fails to build due to change in DamageUnregister API
Status: RESOLVED DUPLICATE of bug 71110
Alias: None
Product: Mesa
Classification: Unclassified
Component: Other (show other bugs)
Version: git
Hardware: Other All
: medium normal
Assignee: mesa-dev
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-12 16:31 UTC by Michał Górny
Modified: 2013-11-01 16:36 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments

Description Michał Górny 2013-10-12 16:31:20 UTC 
A few days ago git xorg-server changed the DamageUnregister proto to:

  DamageUnregister(DamagePtr pDamage);

As a result, mesa's xorg state tracker fails to build:

xorg_driver.c:1025:2: error: too many arguments to function ‘DamageUnregister’
  DamageUnregister(&pScreen->GetScreenPixmap(pScreen)->drawable, ms->damage);
  ^

Please update the mesa code to support the new API (it's enough to omit the drawable).
Comment 1 Emil Velikov 2013-10-12 17:41:14 UTC 
In order not to break builds against current and older X we'll need to do that once X has a release with the change :)
Comment 2 Michał Górny 2013-10-12 17:53:09 UTC 
(In reply to comment #1)
> In order not to break builds against current and older X we'll need to do
> that once X has a release with the change :)

IMO it would be better to check the prototype during configure.
Comment 3 Emil Velikov 2013-11-01 16:36:22 UTC 

*** This bug has been marked as a duplicate of bug 71110 ***

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.