Bug 7075 - make clean should remove cairo.def
Summary: make clean should remove cairo.def
Status: RESOLVED FIXED
Alias: None
Product: cairo
Classification: Unclassified
Component: win32 backend (show other bugs)
Version: 1.1.6
Hardware: x86 (IA32) Linux (All)
: high minor
Assignee: Owen Taylor
QA Contact: cairo-bugs mailing list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-05-30 10:44 UTC by John Steele Scott (t-tec)
Modified: 2006-06-20 05:32 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments

Description John Steele Scott (t-tec) 2006-05-30 10:44:41 UTC 
Hi,

I was puzzled about why I couldn't rebuild cairo with PS or PDF support. It
turned out that cairo.def was not being regenerated after each re-run of configure.

I'm not sure if cairo.def needs an extra dependency specified in the Makefile to
make sure it's fresh, but it should at least be removed during "make clean".
That would have saved me some time.
Comment 1 Behdad Esfahbod 2006-06-14 01:00:33 UTC 
Agreed.

Trivial patch:

diff --git a/src/Makefile.am b/src/Makefile.am
index c982244..2141113 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -233,3 +233,5 @@ install-data-local:
          echo
"****************************************************************" ;     \
          false ;                                                              
        \
         fi
+
+CLEANFILES = cairo.def
Comment 2 Carl Worth 2006-06-14 04:08:36 UTC 
I'm pushing this fix out now.

Behdad,

What's the rationale for burying a useful patch here in bugzilla instead of just
pushing it out into cairo? Please feel free to push obvious fixes like this
straight out.

-Carl
Comment 3 Behdad Esfahbod 2006-06-14 08:35:15 UTC 
Carl: gitophobia.
Comment 4 Ryan Reich 2006-06-20 05:30:36 UTC 
*** Bug 7277 has been marked as a duplicate of this bug. ***
Comment 5 Ryan Reich 2006-06-20 05:32:28 UTC 
Sorry, ignore the duplicate, it was a typo.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.