Bug 70788 - igt/kms_cursor_crc/cursor-white-visible-offscreen fails
Summary: igt/kms_cursor_crc/cursor-white-visible-offscreen fails
Status: CLOSED FIXED
Alias: None
Product: DRI
Classification: Unclassified
Component: DRM/Intel (show other bugs)
Version: unspecified
Hardware: All Linux (All)
: medium normal
Assignee: Intel GFX Bugs mailing list
QA Contact: Intel GFX Bugs mailing list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-23 03:05 UTC by lu hua
Modified: 2017-10-06 14:42 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
dmesg (101.20 KB, text/plain)
2013-10-23 03:05 UTC, lu hua
no flags Details

Description lu hua 2013-10-23 03:05:09 UTC
Created attachment 88021 [details]
dmesg

System Environment:
--------------------------
Platform:  PNV/ILK/SNB/IVB/HSW
Kernel:	(drm-intel-nightly)aabd627ec77463dc9c064ce2735ef71f48a2ec94

Bug detailed description:
---------------------------
It fails on PNV/ILK/SNB/IVB/HSW with -queued and -nightly kernel, and works well on -fixes kernel. It's a new igt case.


output:
Beginning cursor-white-visible-offscreen on crtc 3, connector 7
.................................................Test assertion failure function do_single_test, file kms_cursor_crc.c:166:
Failed assertion: igt_crc_equal(&crcs[0], &test_data->ref_crc)
Subtest cursor-white-visible-offscreen: FAIL


Reproduce steps:
----------------------------
1. ./kms_cursor_crc --run-subtest cursor-white-visible-offscreen
Comment 1 Daniel Vetter 2013-10-27 19:24:21 UTC
Hm, if it works well on fixes but it's broken in -nightly then this means we're looking at a regression for 3.13 ...

Can you please bisect where this bug in -nightly compared to -fixes is introduced?
Comment 2 Ville Syrjala 2013-10-28 12:21:56 UTC
The test should be skipped on -fixes since the crc support isn't present there.

As for the -nightly failure, looks like "[PATCH] drm/i915: Clamp cursor coordinates to int16_t range" didn't get applied yet, which exlains the failure.
Comment 3 Daniel Vetter 2013-10-28 16:56:22 UTC
Patch merged:

commit 92e76c8c7e436a07af3e0b594480ff8689add078
Author: Ville Syrjälä <ville.syrjala@linux.intel.com>
Date:   Mon Oct 21 19:01:58 2013 +0300

    drm/i915: Clamp cursor coordinates to int16_t range
Comment 4 lu hua 2013-10-29 06:23:55 UTC
(In reply to comment #2)
> The test should be skipped on -fixes since the crc support isn't present
> there.
> 
> As for the -nightly failure, looks like "[PATCH] drm/i915: Clamp cursor
> coordinates to int16_t range" didn't get applied yet, which exlains the
> failure.

On -fixes branch, It should be skipped from output info,but the return code is 0.
output:
Test requirement not met in function main, file kms_cursor_crc.c:352:
Test requirement: (!(data.ctl))
No display_crc_ctl found, kernel too old
Subtest cursor-white-visible-onscreen: SKIP
Subtest cursor-white-visible-offscreen: SKIP
Subtest cursor-white-invisible-onscreen: SKIP
Subtest cursor-white-invisible-offscreen: SKIP
Subtest cursor-black-visible-onscreen: SKIP
Subtest cursor-black-visible-offscreen: SKIP
Subtest cursor-black-invisible-onscreen: SKIP
Subtest cursor-black-invisible-offscreen: SKIP

# echo $?
0
Comment 5 Daniel Vetter 2013-10-29 06:47:38 UTC
(In reply to comment #4)
> (In reply to comment #2)
> > The test should be skipped on -fixes since the crc support isn't present
> > there.
> > 
> > As for the -nightly failure, looks like "[PATCH] drm/i915: Clamp cursor
> > coordinates to int16_t range" didn't get applied yet, which exlains the
> > failure.
> 
> On -fixes branch, It should be skipped from output info,but the return code
> is 0.
> output:
> Test requirement not met in function main, file kms_cursor_crc.c:352:
> Test requirement: (!(data.ctl))
> No display_crc_ctl found, kernel too old
> Subtest cursor-white-visible-onscreen: SKIP
> Subtest cursor-white-visible-offscreen: SKIP
> Subtest cursor-white-invisible-onscreen: SKIP
> Subtest cursor-white-invisible-offscreen: SKIP
> Subtest cursor-black-visible-onscreen: SKIP
> Subtest cursor-black-visible-offscreen: SKIP
> Subtest cursor-black-invisible-onscreen: SKIP
> Subtest cursor-black-invisible-offscreen: SKIP
> 
> # echo $?
> 0

Should be also fixed with

commit 7b8784dccf303c4fd9c6a1c2e3f9fae7d00fde2f
Author: Daniel Vetter <daniel.vetter@ffwll.ch>
Date:   Tue Oct 29 07:47:33 2013 +0100

    tests/kms_cursor_crc: Use igt_exit
Comment 6 lu hua 2013-10-31 02:27:04 UTC
It's pass on -nightly branch and not support on -fixes branch now.
Verified, Fixed.
Comment 7 Elizabeth 2017-10-06 14:42:26 UTC
Closing old verified.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.