Bug 70794 - [HSW]s3 fail and call trace
Summary: [HSW]s3 fail and call trace
Status: CLOSED NOTOURBUG
Alias: None
Product: DRI
Classification: Unclassified
Component: DRM/Intel (show other bugs)
Version: unspecified
Hardware: All Linux (All)
: medium normal
Assignee: Intel GFX Bugs mailing list
QA Contact: Intel GFX Bugs mailing list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-23 08:25 UTC by Qingshuai Tian
Modified: 2017-10-06 14:42 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:


Attachments
dmesg of s3 fail (116.76 KB, text/plain)
2013-10-23 08:25 UTC, Qingshuai Tian
no flags Details
dmesg of s3 fail (DP) (116.75 KB, text/plain)
2013-10-25 02:07 UTC, Qingshuai Tian
no flags Details

Description Qingshuai Tian 2013-10-23 08:25:39 UTC
Created attachment 88026 [details]
dmesg of s3 fail

System Environment:
--------------------------
Kernel: (drm-intel-next-queued)d538bbdfde34028b5c5b0ba92b3c2096c5afb82c
Author: Damien Lespiau <damien.lespiau@intel.com>
Date:   Mon Oct 21 14:29:30 2013 +0100

    drm/i915: Use a spin lock to protect the pipe crc struct

Bug detailed description:
-----------------------------
When I test s3 on a HSW desktop ,the machine'll resume immediately after it suspend automatically by itself. And there is call trace in the output.

Reproduce steps:
-----------------------------
1.boot up the machine
2..echo mem > /sys/power/state
Comment 1 Paulo Zanoni 2013-10-24 12:50:34 UTC
What happens if you use DP or eDP instead of HDMI?
Comment 2 Qingshuai Tian 2013-10-25 02:07:01 UTC
Created attachment 88096 [details]
dmesg of s3 fail (DP)

When I test s3 on the machine with DP instead of HDMI, the Call trace disappeared. But the s3 still didn't work.
Comment 3 Paulo Zanoni 2013-10-25 13:12:08 UTC
(In reply to comment #2)
> Created attachment 88096 [details]
> dmesg of s3 fail (DP)
> 
> When I test s3 on the machine with DP instead of HDMI, the Call trace
> disappeared. But the s3 still didn't work.

Can you please try to bisect this problem?

Thanks,
Paulo
Comment 4 Qingshuai Tian 2013-10-28 09:13:40 UTC
I have finished the bisect, and the result shows:

24576d23976746cb52e7700c4cadbf4bc1bc3472 is the first bad commit
commit 24576d23976746cb52e7700c4cadbf4bc1bc3472
Author: Jesse Barnes <jbarnes@virtuousgeek.org>
Date:   Tue Mar 26 09:25:45 2013 -0700

    drm/i915: enable VT switchless resume v3

    With the other bits in place, we can do this safely.

    v2: disable backlight on suspend to prevent premature enablement on resume
    v3: disable CRTCs on suspend to allow RTD3 (Kristen)

    Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
    Reviewed-by: Rodrigo Vivi <rodrigo.vivi@gmail.com>
    Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>

I hope it's helpful.  :)
Comment 5 Daniel Vetter 2013-10-28 09:23:55 UTC
Yup, bisect is helpful. This sounds like a dupe of bug #64379

But I dunno really why DP fails silently, so maybe it's better to track this separately.
Comment 6 Paulo Zanoni 2013-10-28 12:24:57 UTC
Which BIOS version are you using on this machine? Can you please update to the latest?
Comment 7 Paulo Zanoni 2013-10-28 12:27:48 UTC
(In reply to comment #4)
> I have finished the bisect, and the result shows:
> 
> 24576d23976746cb52e7700c4cadbf4bc1bc3472 is the first bad commit
> commit 24576d23976746cb52e7700c4cadbf4bc1bc3472
> Author: Jesse Barnes <jbarnes@virtuousgeek.org>
> Date:   Tue Mar 26 09:25:45 2013 -0700
> 
>     drm/i915: enable VT switchless resume v3
> 
>     With the other bits in place, we can do this safely.
> 
>     v2: disable backlight on suspend to prevent premature enablement on
> resume
>     v3: disable CRTCs on suspend to allow RTD3 (Kristen)
> 
>     Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
>     Reviewed-by: Rodrigo Vivi <rodrigo.vivi@gmail.com>
>     Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> 
> I hope it's helpful.  :)

Just to be clear: even if you use DP instead of HDMI, then S3 won't work, the only difference is that you won't be seeing that calltrace in dmesg. Is this correct?

What I asked you to bisect was the "S3 doesn't work with DP" problem of this bug, since that really should be a recent regression in case it's happening at all.
Comment 8 Qingshuai Tian 2013-10-29 05:19:25 UTC
Yes. The only difference when I use DP instead of HDMI is that I won't see the call trace. But S3 won't work no matter with HDMI or DP.

What I bisected in comment 4 is for the problem "S3 call trace with HDMI". Sorry that I didn't make it clear.

I tried to bisect the "S3 doesn't work with DP" problem of this bug, but I can't find a goog commit on the drm-intel-next-queued branch.
Even when I tested with the "i915.modeset=0" module, S3 still won't work.

I update the BIOS version from "HSWLPTU1.86C.0120.R00.1303312001" to "HSWPTU1.86C.0134.R00.1310022130". But this problem still exits.
Comment 9 Paulo Zanoni 2013-10-29 12:24:01 UTC
(In reply to comment #8)
> Yes. The only difference when I use DP instead of HDMI is that I won't see
> the call trace. But S3 won't work no matter with HDMI or DP.
> 
> What I bisected in comment 4 is for the problem "S3 call trace with HDMI".
> Sorry that I didn't make it clear.
> 
> I tried to bisect the "S3 doesn't work with DP" problem of this bug, but I
> can't find a goog commit on the drm-intel-next-queued branch.
> Even when I tested with the "i915.modeset=0" module, S3 still won't work.
> 
> I update the BIOS version from "HSWLPTU1.86C.0120.R00.1303312001" to
> "HSWPTU1.86C.0134.R00.1310022130". But this problem still exits.

Can you please try to completely blacklist i915.ko and see if the problem still happens? In this case, it's not our bug.
Comment 10 Qingshuai Tian 2013-10-30 01:59:45 UTC
Yes.After I disabled  the i915.ko, the s3 problem still happen.
Comment 11 Chris Wilson 2013-10-30 10:16:51 UTC
We still need to identify which component is failing so that we can file an appropriate bug report.
Comment 12 Elizabeth 2017-10-06 14:42:22 UTC
Closing old verified.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.