Bugzilla – Bug 7083
XCreateColormap returns BadValue when it should return BadMatch
Last modified: 2006-11-04 09:35:06 UTC
In xorg-server/dix/dispatch.c, the ProcCreateColormap function should return
BadMatch but actually retuns BadValue. This happens after the for loop.
According to the man page, "[i]f the visual type is not one supported by the
screen, a BadMatch error results.".
BadValue is (correctly) returned if the alloc parameter is not AllocAll or
I'll attach a patch against xorg-server-1.0.2.
Created attachment 5772 [details] [review]
Proposed patch to return correct error message
The official X11 Protocol Spec agrees:
This request creates a colormap of the specified visual type for the screen
on which the window resides and associates the identifier mid with it.
The visual type must be one supported by the screen (or a Match error results).
fixed in both master and server-1.2-branch, thanks