Bug 70945 - [HSW Bisected]igt/kms_flip/dpms-off-confusion-interruptible causes [drm:intel_pipe_config_compare] *ERROR* mismatch in pipe_bpp (expected 24, found 0)
Summary: [HSW Bisected]igt/kms_flip/dpms-off-confusion-interruptible causes [drm:intel...
Status: CLOSED FIXED
Alias: None
Product: DRI
Classification: Unclassified
Component: DRM/Intel (show other bugs)
Version: unspecified
Hardware: All Linux (All)
: high major
Assignee: Jani Nikula
QA Contact: Intel GFX Bugs mailing list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-28 07:41 UTC by lu hua
Modified: 2016-11-22 08:46 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments
dmesg (127.54 KB, text/plain)
2013-10-28 07:41 UTC, lu hua 		no flags Details
View All

Description lu hua 2013-10-28 07:41:04 UTC 
Created attachment 88208 [details]
dmesg

System Environment:
--------------------------
Platform: Haswell
Kernel:	(drm-intel-fixes)cfa91465f2410f615cba1341cde2f80e736ef58b

Bug detailed description:
---------------------------
It causes [drm:intel_pipe_config_compare] *ERROR* mismatch in pipe_bpp (expected 24, found 0) on haswell with drm-intel-fixes kernel. It doesn't happens on -nightly and -queued kernel.
Following cases also have this issue:
igt/gem_tiled_swapping
igt/kms_render/direct-render
igt/kms_render/gpu-blit

Bisect shows:f22be8c70cf3702b0f11743f2dc5d093b2f8f5d7 is the first bad commit
commit f22be8c70cf3702b0f11743f2dc5d093b2f8f5d7
Author:     Ville Syrjälä <ville.syrjala@linux.intel.com>
AuthorDate: Mon Oct 21 10:52:06 2013 +0300
Commit:     Daniel Vetter <daniel.vetter@ffwll.ch>
CommitDate: Mon Oct 21 09:56:49 2013 +0200

    drm/i915: Add support for pipe_bpp readout

    On CTG+ read out the pipe bpp setting from hardware and fill it into
    pipe config. Also check it appropriately.

    v2: Don't do the pipe_bpp extraction inside the PCH only code block on
        ILK+.
        Avoid the PIPECONF read as we already have read it for the
        PIPECONF_EANBLE check.

    Note: This is already in drm-intel-next-queued as
    commit 42571aefafb1d330ef84eb29418832f72e7dfb4c
    Author: Ville Syrjälä <ville.syrjala@linux.intel.com>
    Date:   Fri Sep 6 23:29:00 2013 +0300

        drm/i915: Add support for pipe_bpp readout

    but is needed for the following bugfix.

    Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
    Reviewed-by: Jani Nikula <jani.nikula@intel.com>
    Cc: stable@vger.kernel.org
    Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>

output:
Using monotonic timestamps
Beginning dpms-off-confusion-interruptible on crtc 3, connector 9
  1024x768 60 1024 1048 1184 1344 768 771 777 806 0xa 0x48 65000
.........................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
dpms-off-confusion-interruptible on crtc 3, connector 9: PASSED

Beginning dpms-off-confusion-interruptible on crtc 5, connector 9
  1024x768 60 1024 1048 1184 1344 768 771 777 806 0xa 0x48 65000
.........................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
dpms-off-confusion-interruptible on crtc 5, connector 9: PASSED

Beginning dpms-off-confusion-interruptible on crtc 7, connector 9
  1024x768 60 1024 1048 1184 1344 768 771 777 806 0xa 0x48 65000
.........................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
dpms-off-confusion-interruptible on crtc 7, connector 9: PASSED

Subtest dpms-off-confusion-interruptible: SUCCESS


Call trace:
[   94.797951] [drm:intel_pipe_config_compare] *ERROR* mismatch in pipe_bpp (expected 24, found 0)
[   94.797952] ------------[ cut here ]------------
[   94.797957] WARNING: CPU: 0 PID: 3761 at drivers/gpu/drm/i915/intel_display.c:8805 check_crtc_state+0x72f/0x776 [i915]()
[   94.797958] pipe state doesn't match!
[   94.797958] Modules linked in: dm_mod snd_hda_codec_realtek snd_hda_codec_hdmi iTCO_wdt iTCO_vendor_support dcdbas pcspkr serio_raw i2c_i801 lpc_ich snd_hda_intel mfd_core snd_hda_codec snd_hwdep shpchp snd_pcm snd_page_alloc snd_timer snd soundcore acpi_cpufreq i915 video button drm_kms_helper drm freq_table
[   94.797966] CPU: 0 PID: 3761 Comm: kms_flip Tainted: G        W    3.12.0-rc5_drm-intel-fixes_cfa914_20131028_+ #1771
[   94.797967] Hardware name: Dell Inc. OptiPlex 9020/0DNKMN, BIOS A02 08/15/2013
[   94.797968]  0000000000000000 0000000000000009 ffffffff81704adc ffff880004c3b9c8
[   94.797969]  ffffffff8103319e ffff880004c3b9c0 ffffffffa0081b91 0000000000000001
[   94.797970]  ffff8800db2b2000 ffff8800db309000 ffff880004c3ba40 ffff8800db2b26d0
[   94.797972] Call Trace:
[   94.797974]  [<ffffffff81704adc>] ? dump_stack+0x41/0x51
[   94.797976]  [<ffffffff8103319e>] ? warn_slowpath_common+0x73/0x8b
[   94.797980]  [<ffffffffa0081b91>] ? check_crtc_state+0x72f/0x776 [i915]
[   94.797982]  [<ffffffff8103324e>] ? warn_slowpath_fmt+0x45/0x4a
[   94.797987]  [<ffffffffa0081b91>] ? check_crtc_state+0x72f/0x776 [i915]
[   94.797993]  [<ffffffffa008bc33>] ? intel_modeset_check_state+0x36f/0x617 [i915]
[   94.797997]  [<ffffffffa000e735>] ? drm_mode_object_find+0x91/0xa1 [drm]
[   94.798001]  [<ffffffffa00122f3>] ? drm_mode_obj_set_property_ioctl+0x162/0x1ec [drm]
[   94.798004]  [<ffffffffa00123a9>] ? drm_mode_connector_property_set_ioctl+0x2c/0x31 [drm]
[   94.798007]  [<ffffffffa000501d>] ? drm_ioctl+0x2a5/0x3c4 [drm]
[   94.798010]  [<ffffffffa001237d>] ? drm_mode_obj_set_property_ioctl+0x1ec/0x1ec [drm]
[   94.798012]  [<ffffffff810e8462>] ? vfs_ioctl+0x1e/0x31
[   94.798013]  [<ffffffff810e8c38>] ? do_vfs_ioctl+0x3ad/0x3ef
[   94.798014]  [<ffffffff810e8cc8>] ? SyS_ioctl+0x4e/0x7e
[   94.798016]  [<ffffffff8170f062>] ? system_call_fastpath+0x16/0x1b
[   94.798017] ---[ end trace e100fc048187f1cd ]---

Reproduce steps:
----------------------------
1. ./kms_flip --run-subtest dpms-off-confusion-interruptible
Comment 1 Daniel Vetter 2013-10-28 08:22:13 UTC 
Jani, can you please figure out which patch we're missing for the -fixes backport of the pipe bpp stuff on hsw vga?
Comment 2 Ville Syrjala 2013-10-28 08:32:28 UTC 
Should be this one:

commit 6801c18c0a43386bb44712cbc028a7e05adb9f0d
Author: Ville Syrjälä <ville.syrjala@linux.intel.com>
Date:   Tue Sep 24 14:24:05 2013 +0300

    drm/i915: Add HSW CRT output readout support
Comment 3 Daniel Vetter 2013-10-28 08:54:55 UTC 
Ok, I've applied the backport to -fixes, please test.
Comment 4 lu hua 2013-10-31 06:14:38 UTC 
Fixed.
Comment 5 lu hua 2013-10-31 06:15:00 UTC 
Verified.Fixed.
Comment 6 Jari Tahvanainen 2016-11-22 08:46:15 UTC 
Closing verified+fixed. commit b8cab706.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.