Bug 71218 - Don’t unconditionally enable -Werror for non-release builds
Summary: Don’t unconditionally enable -Werror for non-release builds
Status: RESOLVED FIXED
Alias: None
Product: nice
Classification: Unclassified
Component: General (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Dafydd Harries
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-04 12:40 UTC by Philip Withnall
Modified: 2014-03-06 22:20 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
Don’t unconditionally enable -Werror for non-release builds (2.05 KB, patch)
2013-11-04 12:41 UTC, Philip Withnall
Details | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Philip Withnall 2013-11-04 12:40:41 UTC
If the user has some warning flags in their CFLAGS which the main developers don’t have enabled, this can cause spurious build failures.

Patch coming which disables this behaviour by default unless libnice is configured with --enable-compile-warnings=error (which mimics the behaviour of the gnome-common macro used by many other projects).
Comment 1 Philip Withnall 2013-11-04 12:41:11 UTC
Created attachment 88606 [details] [review]
Don’t unconditionally enable -Werror for non-release builds
Comment 2 Olivier Crête 2014-03-06 22:20:45 UTC
This is merged


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.