Bug 71245 - glib-demo: Small style fixes
Summary: glib-demo: Small style fixes
Status: RESOLVED FIXED
Alias: None
Product: poppler
Classification: Unclassified
Component: glib frontend (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: poppler-bugs
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-05 07:54 UTC by Andrés Gómez García
Modified: 2013-11-05 08:38 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
Patch fixing small code style mistakes in the glib-demo (2.58 KB, patch)
2013-11-05 07:57 UTC, Andrés Gómez García
Details | Splinter Review

Description Andrés Gómez García 2013-11-05 07:54:57 UTC
There some code styling mistakes in the glib-demo
Comment 1 Andrés Gómez García 2013-11-05 07:57:10 UTC
Created attachment 88669 [details] [review]
Patch fixing small code style mistakes in the glib-demo
Comment 2 Carlos Garcia Campos 2013-11-05 08:38:12 UTC
Comment on attachment 88669 [details] [review]
Patch fixing small code style mistakes in the glib-demo

Review of attachment 88669 [details] [review]:
-----------------------------------------------------------------

Thanks for the patch. There are actually 3 different issues, so I've split the patch and pushed to git master.

::: glib/demo/main.c
@@ +122,5 @@
>  	return treeview;
>  }
>  
>  static GtkWidget *
> +pgd_demo_notebook_create (PopplerDocument *document)

Good catch!


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.