The following patch fixes building with C89 compilers like gcc 2.
Created attachment 5833 [details] [review] C89 fixes (patch against xorg-server 1.1.0)
Thanks for the patch! Fix checked into git: exa/exa.c | 5 ++++- hw/xfree86/common/xf86Config.c | 9 ++++++--- 2 files changed, 10 insertions(+), 4 deletions(-) New commits: diff-tree 179737d4a07ed10a734fe017b5680f8e78ffda96 (from 6bd4c254396cb0f4e8ae21ff455ebb15cd9f4f10) Author: Jens Granseuer <jensgr@gmx.net> Date: Wed Jun 7 01:46:00 2006 -0700 Bug 7145: fix build with gcc 2.95 & other c89 compilers Move variable declarations to start of blocks as required by c89
This same problem is still present in 1.2.0...
Sorry about the phenomenal bug spam, guys. Adding xorg-team@ to the QA contact so bugs don't get lost in future.
Created attachment 8986 [details] [review] patch for 7.2.99.901 And here's an updated patch against 7.2RC1 which still exhibits the same issues and some shiny new ones.
Created attachment 8987 [details] [review] real patch for 1.2.99.901 Gah, already getting all those patches mixed up. This is the correct one.
Fix checked into git master for inclusion in xserver-1.4: GL/glx/glxcmdsswap.c | 4 ++-- randr/rrcrtc.c | 2 +- randr/rroutput.c | 2 +- randr/rrpointer.c | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) New commits: diff-tree 689d52b6242434507a64a8fff27b01607628c393 (from fe7b8f4237874e3e45fe25a6bf06faddfa1ab8e1) Author: Jens Granseuer <jensgr@gmx.net> Date: Mon Mar 5 15:31:44 2007 -0800 Bugzilla #7145: fix build with gcc 2.95 Bugzilla #7145: <http://bugs.freedesktop.org/show_bug.cgi?id=7145> Patch #8987: <http://bugs.freedesktop.org/attachment.cgi?id=8987>
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.