Bug 71758 - Every structure having a fixed size field after a variadic field/list is broken
Summary: Every structure having a fixed size field after a variadic field/list is broken
Status: RESOLVED MOVED
Alias: None
Product: XCB
Classification: Unclassified
Component: Protocol (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: xcb mailing list dummy
QA Contact: xcb mailing list dummy
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-18 20:19 UTC by Uli Schlachter
Modified: 2019-02-16 19:39 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Description Uli Schlachter 2013-11-18 20:19:16 UTC
See: http://lists.freedesktop.org/archives/xcb/2013-October/008689.html

To quote from that mail (more details are in there):

First, the summary if you don't want to read the whole story: It looks
like _every_ structure having a fixed size field after a variadic
field/list is broken! Most other extensions are not affected as they've
the variadic stuff at the end of a structure - not intermixed with fixed
size fields.

[...]

    This struct has a
    - fixed size field (nameLength)
    - variadic list (name)
    - fixed size field (valueLength)
    - variadic list (value).

    Now, look at the generated structure:
    typedef struct xcb_xkb_property_t {
        uint16_t nameLength;
        uint16_t valueLength; <-- doesn't belong here
    } xcb_xkb_property_t;
Comment 1 Daniel Martin 2013-11-21 12:59:23 UTC
The struct "Property" and affected fields in the "GetKbdByName" request are commented out upstream. Additionally, I've instructed c_client.py to watch out for equaly related problems and couldn't find any.

I would like to close this bug with the hope that I didn't missed something. And yes, it's not realy fixed, but imo in its current state shouldn't block a release.
Comment 2 GitLab Migration User 2019-02-16 19:39:43 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/xorg/proto/xcbproto/issues/2.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.