Bug 71773 - [GM45]: font corruption is back after 2a59eadf8165bd70780ac16220456c6196ac3ff1
Summary: [GM45]: font corruption is back after 2a59eadf8165bd70780ac16220456c6196ac3ff1
Status: RESOLVED DUPLICATE of bug 55500
Alias: None
Product: xorg
Classification: Unclassified
Component: Driver/intel (show other bugs)
Version: git
Hardware: Other All
: medium normal
Assignee: Chris Wilson
QA Contact: Intel GFX Bugs mailing list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-19 07:51 UTC by Arkadiusz Miskiewicz
Modified: 2013-12-22 09:48 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Description Arkadiusz Miskiewicz 2013-11-19 07:51:40 UTC
Commit
commit 2a59eadf8165bd70780ac16220456c6196ac3ff1
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date:   Sun Jul 7 09:13:49 2013 +0100

    sna/gen4: Remove the glyph mask hack and tune the flush w/a
    
    Remove the hack from the glyph path to force the use of an auxiliary
    channel, and reduce the maximum amount of inflight vertices until we can
    then render glyphs with no corruption (at least in my test case).
    
    Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>

reverts
--- a/src/sna/sna_glyphs.c
+++ b/src/sna/sna_glyphs.c
@@ -1287,7 +1287,7 @@ next_image:
                                             __FUNCTION__,
                                             (int)p->atlas->format,
                                             (int)(format->depth << 24 | format->format)));
-                                       if (p->atlas->format == (format->depth << 24 | format->format)) {
+                                       if (p->atlas->format == (format->depth << 24 | format->format) && (sna->kgem.gen >> 3) != 4) /* XXX cache corruption? 
how? */ {
                                                ok = sna->render.composite(sna, PictOpAdd,
                                                                           p->atlas, NULL, mask,
                                                                           0, 0, 0, 0, 0, 0,


and fonts corruption is back on my
00:02.0 VGA compatible controller: Intel Corporation Mobile 4 Series Chipset Integrated Graphics Controller (rev 07) (prog-if 00 [VGA controller])
(thinkpad t400)

Reverting chunk above and fonts corruption is gone.

kde4.11 + xserver1.14.4 + kernel 3.12 here.
Comment 1 Chris Wilson 2013-11-19 09:42:09 UTC
I killed the hack because my investigations lead me to believe that it was the same underlying bug as 55500 (and after adjusting the w/a, the hack was no longer required locally).
Comment 2 Chris Wilson 2013-12-17 18:06:50 UTC
Arkadiusz, did the recent commit confirm that this is just another aspect of bug 55500?
Comment 3 Arkadiusz Miskiewicz 2013-12-21 18:40:53 UTC
It seems to be the same. Running for a few days and I'm not seeing corruption from this bugreport.
Comment 4 Chris Wilson 2013-12-22 09:48:59 UTC
Back to Plan A.

*** This bug has been marked as a duplicate of bug 55500 ***


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.