Bug 71894 - [PATCH] pkexec: Work around systemd injecting broken XDG_RUNTIME_DIR
Summary: [PATCH] pkexec: Work around systemd injecting broken XDG_RUNTIME_DIR
Status: RESOLVED FIXED
Alias: None
Product: PolicyKit
Classification: Unclassified
Component: daemon (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: David Zeuthen (not reading bugmail)
QA Contact: David Zeuthen (not reading bugmail)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-21 22:42 UTC by Colin Walters
Modified: 2013-11-22 17:04 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments
0001-pkexec-Work-around-systemd-injecting-broken-XDG_RUNT.patch (2.00 KB, text/plain)
2013-11-21 22:42 UTC, Colin Walters 		Details
View All

Description Colin Walters 2013-11-21 22:42:24 UTC 
Created attachment 89608 [details]
0001-pkexec-Work-around-systemd-injecting-broken-XDG_RUNT.patch

This workaround isn't too much code, and it's often better to fix bugs
in two places anyways.

For more information:

See https://bugzilla.redhat.com/show_bug.cgi?id=753882
See http://lists.freedesktop.org/archives/systemd-devel/2013-November/014370.html
Comment 1 Miloslav Trmac 2013-11-22 15:03:06 UTC 
One nit, the bugzilla link in the patch is wrong.
Comment 2 Miloslav Trmac 2013-11-22 15:48:24 UTC 
Comment on attachment 89608 [details]
0001-pkexec-Work-around-systemd-injecting-broken-XDG_RUNT.patch

ACK on the patch in general.
Comment 3 Miloslav Trmac 2013-11-22 15:49:44 UTC 
Sorry, confused...

The function comment should lead to https://bugzilla.redhat.com/show_bug.cgi?id=753882 .

Stylistically I'd prefer the function to express the predicate that is true when it returns TRUE, e.g. xdg_runtime_dir_is_valid().
Comment 4 Colin Walters 2013-11-22 17:03:36 UTC 
(In reply to comment #3)
> The function comment should lead to
> https://bugzilla.redhat.com/show_bug.cgi?id=753882 .

Oops, too many Bugzilla tabs open, fixed.

> Stylistically I'd prefer the function to express the predicate that is true
> when it returns TRUE, e.g. xdg_runtime_dir_is_valid().

I called it xdg_runtime_dir_is_owned_by() which seems even clearer.  Thanks for the review!

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.