Bug 72191 - FORMATTING: Fill Format Mode dosn't work.
Summary: FORMATTING: Fill Format Mode dosn't work.
Status: RESOLVED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
4.0.6.2 release
Hardware: Other All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: BSA
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-01 08:42 UTC by Tomofumi Yagi
Modified: 2014-02-22 14:53 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:

Attachments
ScreenShot 1(LibreOffice 4.0 or 4.1). (42.38 KB, image/png)
2013-12-01 22:06 UTC, Tomofumi Yagi 		Details
ScreenShot 2(LibreOffice 4.2 or later). (44.09 KB, image/png)
2013-12-01 22:09 UTC, Tomofumi Yagi 		Details
Patch for LibreOffice 4.1 (3.58 KB, patch)
2013-12-01 22:22 UTC, Tomofumi Yagi 		Details
Cherry-picking-from-commit-38b8e742872b2cbdba93f4d1b84c8f09b5ab38ff (4.06 KB, patch)
2013-12-05 12:29 UTC, Tomofumi Yagi 		Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tomofumi Yagi 2013-12-01 08:42:24 UTC 
Problem description: 
"Fill Format Mode" dosn't work.
When I click "Fill Format Mode" button,Nothing happens.

Steps to reproduce:
1. Start a Writer.
2. Open "Style and Formatting" dialog.
3. Click "Fill Format Mode" button.

Current behavior:
Nothing happens.

Expected behavior:
Enable "Fill Format Mode" and Image of the mouse pointer changes.

On LibreOffice 4.2.x and master,this bug does not reproduce.  
Next command line will fix this bug. 

git diff libreoffice-4-1 master sfx2/source/dialog/templdlg.cxx | patch -p1 && make

Operating System: All
Version: 4.0.6.2 release
Comment 1 Tomofumi Yagi 2013-12-01 09:00:08 UTC 
Complement:
LibreOffice 4.0.6 has this bug.
LibreOffice 4.1.3 has this bug.
LibreOffice 4.2 or later does *not* have this bug.
Comment 2 Tomofumi Yagi 2013-12-01 22:06:58 UTC 
Created attachment 90063 [details]
ScreenShot 1(LibreOffice 4.0 or 4.1).

I attach ScreenShot of "Style and Formatting"Dialog(LibreOffice 4.0 or 4.1).

Nothing happens when click "Fill Format Mode" button.
Comment 3 Tomofumi Yagi 2013-12-01 22:09:40 UTC 
Created attachment 90064 [details]
ScreenShot 2(LibreOffice 4.2 or later).

I attach ScreenShot of "Style and Formatting" Dialog(LibreOffice 4.2 or later).

Enable "Fill Format Mode" when click "Fill Format Mode" button.
Comment 4 Tomofumi Yagi 2013-12-01 22:22:03 UTC 
Created attachment 90067 [details]
Patch for LibreOffice 4.1

This patch fixes the bug.

This patch was created by next command line.

$ git diff libreoffice-4-1 master sfx2/source/dialog/templdlg.cxx
Comment 5 Jacques Guilleron 2013-12-04 14:56:05 UTC 
Hello Tomofumi Yagi,

I reproduce with LO 4.1.3.2 & Windows 7 Home Premium.
I confirm this is not the case with LO 4.2.0.0.beta1
Build ID: f4ca7b35f580827ad2c69ea6d29f7c9b48ebbac7
and LO 3.6.6.2 portable.
Comment 6 Tomofumi Yagi 2013-12-05 12:21:50 UTC 
(In reply to comment #5)

Thanks for your comments - Jacques Guilleron,

I think the following patch fixes this bug.

"Related: fdo#67461 consider hierarchical view"
( author Caolán McNamara <caolanm@redhat.com>
  http://cgit.freedesktop.org/libreoffice/core/commit/?id=38b8e742872b2cbdba93f4d1b84c8f09b5ab38ff )
Comment 7 Tomofumi Yagi 2013-12-05 12:29:06 UTC 
Created attachment 90301 [details]
Cherry-picking-from-commit-38b8e742872b2cbdba93f4d1b84c8f09b5ab38ff

I again attach a patch for LibreOffice 4.1.
Comment 8 Niklas Johansson 2014-02-22 14:53:50 UTC 
I can confirm that the issue does no longer exist in LO 4.1.5 or 4.2 (but in 4.1.3). Therefore I believe it is time to close this bug as resolved.