Bug 7234 - Do not regenerate cairo-features.h on each configure run
Summary: Do not regenerate cairo-features.h on each configure run
Status: RESOLVED FIXED
Alias: None
Product: cairo
Classification: Unclassified
Component: general (show other bugs)
Version: 1.1.8
Hardware: x86 (IA32) Linux (All)
: high normal
Assignee: Carl Worth
QA Contact: cairo-bugs mailing list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-06-15 01:37 UTC by Yevgen Muntyan
Modified: 2006-06-21 04:17 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
patch (1.85 KB, patch)
2006-06-15 01:39 UTC, Yevgen Muntyan
Details | Splinter Review
another patch (2.99 KB, patch)
2006-06-15 02:01 UTC, Yevgen Muntyan
Details | Splinter Review

Description Yevgen Muntyan 2006-06-15 01:37:02 UTC
Do not regenerate cairo-features.h on each configure run
Comment 1 Yevgen Muntyan 2006-06-15 01:39:40 UTC
Created attachment 5915 [details] [review]
patch

Unortunately I could not do 'make distcheck' because "52 of 87 tests failed".
Why distcheck does that anyway?
Comment 2 Yevgen Muntyan 2006-06-15 02:01:46 UTC
Created attachment 5916 [details] [review]
another patch
Comment 3 Yevgen Muntyan 2006-06-15 11:41:35 UTC
It passes 'make distcheck'; the generated file doesn't get into tarball; it gets
generated in a fresh tarball (and in not-fresh source dir too, of course); i.e.
seems to be working.
Comment 4 Behdad Esfahbod 2006-06-15 15:13:53 UTC
I don't see the benefit of doing it in the Makefile.  It just needs to not
recreate if the contents are not changed, but that can be done in configure.
Comment 5 Behdad Esfahbod 2006-06-15 15:26:32 UTC
I'm actually getting rid of cairo-features.h.in template...
Comment 6 Carl Worth 2006-06-15 15:30:01 UTC
Just doing it the configure script sounds great to me.

I wouldn't care if this were with a .in template plus a conditional copy or if
the file were just generated "manually", (which would have the nice side effect
of getting rid of the ugly blank lines currently in cairo-features.h).

-Carl
Comment 7 Behdad Esfahbod 2006-06-21 04:17:55 UTC
Committed.

commit f71313d427565cb37a25393ff8a5a2ffdcfb798b
Author: Behdad Esfahbod <behdad@behdad.org>
Date:   Wed Jun 21 07:00:34 2006 -0400

    Minor refinements, mostly to configure.in.

commit c88bab66ab258e0bbd2cb80eaf4edc9e5f1ad6f0
Author: Behdad Esfahbod <behdad@behdad.org>
Date:   Wed Jun 21 06:25:01 2006 -0400

    Make configure generate cairo-features.h. Generate AC_DEFINE and AM_CONDITIONALS

    for all CAIRO_HAS_*  in CAIRO_BACKEND_ENABLE.



Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.